Fix bundler install for docker-container

[whotwagner]

Bundler install in the docker-container was broken because we seperated development and test environments. This PR fixes the broken bundler configuration for docker-containers

Summary by Sourcery

Fixes the broken bundler configuration for docker-containers by including development and test dependencies during bundle install in the Dockerfile. This ensures that all necessary gems are available in the container environment.

Build:

• Include development and test dependencies during bundle install in the Dockerfile.
• Configure bundler to not exclude development and test groups.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes the broken bundler configuration for docker-containers. The primary issue was that the separation of development and test environments was not correctly handled during the bundle install process within the Docker container. This resulted in missing dependencies and potential runtime errors. The fix involves adjusting the Gemfile to include necessary gems outside of specific groups and modifying the Dockerfile to correctly install dependencies for the production environment.

Updated class diagram for Gemfile dependencies

classDiagram
    class Gemfile {
        -source 'https://rubygems.org'
        -gem 'activerecord'
        -gem 'dalli'
        +gem 'debug'
        -gem 'erubis'
        -gem 'i18n'
        -gem 'puma'
        -gem 'rack-attack'
        -gem 'rackup'
        -gem 'rake'
        -gem 'require_all'
        +gem 'rspec'
        -gem 'rufus-scheduler'
        -gem 'sinatra'
        -gem 'sinatra-activerecord'
        -gem 'sprockets'
        -gem 'sqlite3'
        -group :development
            -gem 'brakeman'
            -gem 'i18n-tasks'
            -gem 'overcommit'
            -gem 'rerun'
            -gem 'rubocop'
            -gem 'rubocop-performance'
            -gem 'rubocop-rails'
        -group :test
            -gem 'database_cleaner'
            -gem 'faker'
            -gem 'rack-test'
    }

    note for Gemfile "'debug' and 'rspec' gems moved out of development/test groups"

Loading

File-Level Changes

Change	Details	Files
Move debug and rspec gems to the global scope in the Gemfile.	Moved debug gem from the development group to the global scope. Moved rspec gem from the test group to the global scope.	Gemfile
Configure bundler to install gems without the development and test groups and update the bundle install command in the Dockerfile.	Added a bundler configuration to ignore the development and test groups. Modified the bundle install command in the Dockerfile to install all gems without excluding any groups.	Dockerfile

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @whotwagner - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using multi-stage builds to avoid including development and test dependencies in the final image.
• It might be helpful to add a comment explaining why the without config is being set locally.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}