Skip to content
This repository was archived by the owner on Feb 21, 2023. It is now read-only.

Redis hash and string commands #15

Closed
wants to merge 14 commits into from
Closed

Redis hash and string commands #15

wants to merge 14 commits into from

Conversation

jettify
Copy link
Contributor

@jettify jettify commented Jun 18, 2014

I have implemented hash commands. Solution for type casting is some what ugly, anyway I need to start from somewhere, so please review. Bit later I will add more method arguments checks, for now I need general idea validation.

@popravich
Copy link
Contributor

Ok, I've looked throught and here is my thoughts.
I'am not really happy with encoder=... parameter:

  • first of all its name -- its purpose to decode reponse but it named 'encoder' -- this is confusing.
  • second (and major reason why I discorage this) -- I think decoding Redis responses is up to
    end-user of the library.

I aggree that working with raw bytes is not a very good idea, so here is the ticket for thinking on how to deal with it #16.

@jettify
Copy link
Contributor Author

jettify commented Jun 20, 2014

You are right, my bad.

  • ^encoder^ removed
  • until response decoding #16 is not resolved, I assume that everything is bytes, and end user is responsible for decoding

@jettify jettify changed the title Redis hash commands (draft) Redis hash and commands Jun 24, 2014
@jettify jettify changed the title Redis hash and commands Redis hash and string commands Jun 24, 2014
@jettify
Copy link
Contributor Author

jettify commented Jul 2, 2014

I'll decompose this PR to smaller parts.

@jettify jettify closed this Jul 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants