Remove pytest_plugin #10762
Draft
Remove pytest_plugin #10762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 13 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
Missing change log? |
for more information, see https://pre-commit.ci
… drop-pytest-plugin
for more information, see https://pre-commit.ci
… drop-pytest-plugin
for more information, see https://pre-commit.ci
… drop-pytest-plugin
for more information, see https://pre-commit.ci
webknjaz
reviewed
Apr 22, 2025
tests/conftest.py
Outdated
| @@ -39,7 +39,8 @@ | |||
| uvloop = None # type: ignore[assignment] | |||
|
|
|||
|
|
|||
| pytest_plugins = ("aiohttp.pytest_plugin", "pytester") | |||
| pytest_plugins = ("pytest_asyncio", "pytest_aiohttp", "pytester") | |||
There was a problem hiding this comment.
Suggested change
| pytest_plugins = ("pytest_asyncio", "pytest_aiohttp", "pytester") | |
| pytest_plugins = ("pytester",) |
There was a problem hiding this comment.
I originally intended to add pytest_aiohttp to enforce it as a required plugin. Might help downstream packagers avoid getting confused by the change.
There was a problem hiding this comment.
Or we could just add a changelog fragment..
There was a problem hiding this comment.
Or we could do both...
There was a problem hiding this comment.
Just add a code comment explaining the motivation.
for more information, see https://pre-commit.ci
… drop-pytest-plugin
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodSpeed Performance ReportMerging #10762 will not alter performanceComparing Summary
Benchmarks breakdown
|
for more information, see https://pre-commit.ci
… drop-pytest-plugin
Dreamsorcerer
commented
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be maintained exclusively in pytest-aiohttp going forwards.