warning: large size difference between variants --> node/src/cli.rs:73:1 | 73 | / pub enum Subcommand { 74 | | /// Key management cli utilities 75 | | #[clap(subcommand)] 76 | | Key(sc_cli::KeySubcommand), | | -------------------------- the second-largest variant contains at least 240 bytes ... | 116 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd), | | ----------------------------------------------- the largest variant contains at least 592 bytes 117 | | } | |_^ the entire enum is at least 592 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 116 - Benchmark(frame_benchmarking_cli::BenchmarkCmd), 116 + Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>), |

warning: unneeded `return` statement --> node/src/chain_spec/mod.rs:45:9 | 45 | return RobonomicsFamily::Mainnet; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 45 - return RobonomicsFamily::Mainnet; 45 + RobonomicsFamily::Mainnet |

warning: this function has too many arguments (9/7) --> node/service/src/parachain.rs:302:1 | 302 | #[sc_tracing::logging::prefix_logs_with("Parachain")] | ^---------------------------------------------------- | | | _in this procedural macro expansion | | 303 | | pub async fn new_service<RuntimeApi, RB, BIQ, BIC>( 304 | | parachain_config: Configuration, 305 | | polkadot_config: Configuration, ... | 338 | | bool, 339 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>, | |_______________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: this warning originates in the attribute macro `sc_tracing::logging::prefix_logs_with` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: this expression creates a reference which is immediately dereferenced by the compiler --> node/service/src/parachain.rs:254:13 | 254 | &config, | ^^^^^^^ help: change this to: `config` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: very complex type used. Consider factoring parts into `type` definitions --> node/service/src/parachain.rs:200:6 | 200 | ) -> Result< | ______^ 201 | | PartialComponents< 202 | | ParachainClient<RuntimeApi>, 203 | | ParachainBackend, ... | 213 | | sc_service::Error, 214 | | > | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

warning: this function has too many arguments (12/7) --> node/service/src/parachain.rs:121:1 | 121 | / pub fn build_open_consensus<RuntimeApi>( 122 | | para_id: ParaId, 123 | | lighthouse_account: AccountId, 124 | | client: Arc<ParachainClient<RuntimeApi>>, ... | 135 | | _force_authoring: bool, 136 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error> | |__________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: using `clone` on type `Option<&Registry>` which implements the `Copy` trait --> node/service/src/parachain.rs:115:9 | 115 | registry.clone(), | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `registry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `Role` which implements the `Copy` trait --> node/service/src/dev.rs:226:16 | 226 | let role = config.role.clone(); | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.role` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> node/service/src/dev.rs:101:13 | 101 | &config, | ^^^^^^^ help: change this to: `config` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: very complex type used. Consider factoring parts into `type` definitions --> node/service/src/dev.rs:58:6 | 58 | ) -> Result< | ______^ 59 | | sc_service::PartialComponents< 60 | | FullClient, 61 | | FullBackend, ... | 71 | | ServiceError, 72 | | > { | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

warning: use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead --> node/service/src/parachain.rs:494:9 | 494 | start_full_node(params)?; | ^^^^^^^^^^^^^^^

warning: use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead --> node/service/src/parachain.rs:480:9 | 480 | start_collator(params).await?; | ^^^^^^^^^^^^^^

warning: use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead --> node/service/src/parachain.rs:30:5 | 30 | start_full_node, BuildNetworkParams, CollatorSybilResistance, StartCollatorParams, | ^^^^^^^^^^^^^^^

warning: use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead --> node/service/src/parachain.rs:29:70 | 29 | build_network, build_relay_chain_interface, prepare_node_config, start_collator, | ^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> runtime/dev/src/lib.rs:880:13 | 872 | / fn dispatch_benchmark( 873 | | config: frame_benchmarking::BenchmarkConfig 874 | | ) -> Result<Vec<frame_benchmarking::BenchmarkBatch>, sp_runtime::RuntimeString> { | |_______________________________________________________________________________________- move the `impl` block outside of this associated function `dispatch_benchmark` ... 880 | impl frame_system_benchmarking::Config for Runtime {} | ^^^^^---------------------------------^^^^^------- | | | | | `Runtime` is not local | `Config` is not local | = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: `#[warn(non_local_definitions)]` on by default

warning: unneeded `return` statement --> runtime/dev/src/lib.rs:869:13 | 869 | return (list, storage_info) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 869 - return (list, storage_info) 869 + (list, storage_info) |

warning: this operation has no effect --> runtime/dev/src/lib.rs:587:37 | 587 | pub const MinimalBid: Balance = 1 * XRT; | ^^^^^^^ help: consider reducing it to: `XRT` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/dev/src/lib.rs:426:45 | 426 | pub const DataDepositPerByte: Balance = 1 * COASE; | ^^^^^^^^^ help: consider reducing it to: `COASE` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/dev/src/lib.rs:407:46 | 407 | pub const PreimageBaseDeposit: Balance = 1 * XRT; | ^^^^^^^ help: consider reducing it to: `XRT` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/dev/src/lib.rs:263:44 | 263 | pub const MinVestedTransfer: Balance = 1 * XRT; | ^^^^^^^ help: consider reducing it to: `XRT` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> runtime/dev/src/lib.rs:206:45 | 206 | pub const ExistentialDeposit: Balance = 1 * COASE; | ^^^^^^^^^ help: consider reducing it to: `COASE` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op = note: `#[warn(clippy::identity_op)]` on by default

warning: use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead --> runtime/dev/src/lib.rs:874:74 | 874 | ) -> Result<Vec<frame_benchmarking::BenchmarkBatch>, sp_runtime::RuntimeString> { | ^^^^^^^^^^^^^

warning: use of deprecated macro `sp_runtime::create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!() --> runtime/dev/src/lib.rs:73:5 | 73 | create_runtime_str, generic, impl_opaque_keys, | ^^^^^^^^^^^^^^^^^^

warning: use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!() --> runtime/dev/src/lib.rs:97:16 | 97 | impl_name: create_runtime_str!("robonomics-dev-airalab"), | ^^^^^^^^^^^^^^^^^^

warning: use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!() --> runtime/dev/src/lib.rs:96:16 | 96 | spec_name: create_runtime_str!("robonomics-dev"), | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: unused import: `sp_genesis_builder::PresetId` --> runtime/dev/src/lib.rs:70:5 | 70 | use sp_genesis_builder::PresetId; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: this match could be written as a `let` statement --> frame/lighthouse/src/lib.rs:215:9 | 215 | / match InherentError::try_from(&INHERENT_IDENTIFIER, error)? { 216 | | o => Some(Err(sp_inherents::Error::Application(Box::from(o)))), 217 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding = note: `#[warn(clippy::match_single_binding)]` on by default help: consider using a `let` statement | 215 ~ let o = InherentError::try_from(&INHERENT_IDENTIFIER, error)?; 216 + Some(Err(sp_inherents::Error::Application(Box::from(o)))) |

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/lighthouse/src/lib.rs:100:19 | 100 | pub fn set(origin: OriginFor<T>, lighthouse: T::AccountId) -> DispatchResultWithPostInfo { | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>` --> frame/lighthouse/src/lib.rs:100:19 | 100 | pub fn set(origin: OriginFor<T>, lighthouse: T::AccountId) -> DispatchResultWithPostInfo { | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead --> frame/lighthouse/src/lib.rs:159:23 | 159 | Other(sp_runtime::RuntimeString), | ^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/digital-twin/src/lib.rs:84:26 | 84 | pub fn set_source( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>` --> frame/digital-twin/src/lib.rs:84:26 | 84 | pub fn set_source( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/digital-twin/src/lib.rs:73:22 | 73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo { | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>` --> frame/digital-twin/src/lib.rs:73:22 | 73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo { | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: this let-binding has unit value --> frame/digital-twin/src/lib.rs:83:26 | 83 | #[pallet::weight(50_000)] | ^^^^^^ help: omit the `let` binding: `50_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/digital-twin/src/lib.rs:72:26 | 72 | #[pallet::weight(50_000)] | ^^^^^^ help: omit the `let` binding: `50_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/digital-twin/src/lib.rs:84:16 | 84 | pub fn set_source( | ^^^^^^^^^^ help: omit the `let` binding: `set_source;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/digital-twin/src/lib.rs:73:16 | 73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo { | ^^^^^^ help: omit the `let` binding: `create;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default

warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/digital-twin/src/lib.rs:83:26 | 83 | #[pallet::weight(50_000)] | ^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/digital-twin/src/lib.rs:72:26 | 72 | #[pallet::weight(50_000)] | ^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/digital-twin/src/lib.rs:84:16 | 84 | pub fn set_source( | ^^^^^^^^^^

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/rws/src/lib.rs:419:29 | 419 | pub fn start_auction( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>` --> frame/rws/src/lib.rs:419:29 | 419 | pub fn start_auction( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/rws/src/lib.rs:391:32 | 391 | pub fn set_subscription( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>` --> frame/rws/src/lib.rs:391:32 | 391 | pub fn set_subscription( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>` --> frame/rws/src/lib.rs:372:26 | 372 | pub fn set_oracle( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/rws/src/lib.rs:350:27 | 350 | pub fn set_devices( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>` --> frame/rws/src/lib.rs:350:27 | 350 | pub fn set_devices( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/rws/src/lib.rs:307:19 | 307 | pub fn bid( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>` --> frame/rws/src/lib.rs:307:19 | 307 | pub fn bid( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/rws/src/lib.rs:275:20 | 275 | pub fn call( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: this let-binding has unit value --> frame/rws/src/lib.rs:418:26 | 418 | #[pallet::weight(100_000)] | ^^^^^^^ help: omit the `let` binding: `100_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:390:26 | 390 | #[pallet::weight(100_000)] | ^^^^^^^ help: omit the `let` binding: `100_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:371:26 | 371 | #[pallet::weight(100_000)] | ^^^^^^^ help: omit the `let` binding: `100_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:419:16 | 419 | pub fn start_auction( | ^^^^^^^^^^^^^ help: omit the `let` binding: `start_auction;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:391:16 | 391 | pub fn set_subscription( | ^^^^^^^^^^^^^^^^ help: omit the `let` binding: `set_subscription;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:372:16 | 372 | pub fn set_oracle( | ^^^^^^^^^^ help: omit the `let` binding: `set_oracle;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:350:16 | 350 | pub fn set_devices( | ^^^^^^^^^^^ help: omit the `let` binding: `set_devices;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/rws/src/lib.rs:307:16 | 307 | pub fn bid( | ^^^ help: omit the `let` binding: `bid;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this expression creates a reference which is immediately dereferenced by the compiler --> frame/rws/src/lib.rs:471:60 | 471 | T::AuctionCurrency::slash_reserved(&subscription_id, auction.best_price); | ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: redundant pattern matching, consider using `is_ok()` --> frame/rws/src/lib.rs:437:20 | 437 | if let Ok(_) = <AuctionQueue<T>>::mutate(|queue| queue.try_push(index.clone())) { | -------^^^^^------------------------------------------------------------------- help: try: `if <AuctionQueue<T>>::mutate(|queue| queue.try_push(index.clone())).is_ok()` | = note: this will change drop order of the result, as well as all temporaries = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default

warning: this let-binding has unit value --> frame/rws/src/lib.rs:423:13 | 423 | let _ = ensure_root(origin)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `ensure_root(origin)?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default

warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait --> frame/rws/src/lib.rs:334:38 | 334 | auction.best_price = amount.clone(); | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait --> frame/rws/src/lib.rs:332:54 | 332 | T::AuctionCurrency::reserve(&sender, amount.clone())?; | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait --> frame/rws/src/lib.rs:328:38 | 328 | auction.best_price = amount.clone(); | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: this expression creates a reference which is immediately dereferenced by the compiler --> frame/rws/src/lib.rs:326:47 | 326 | T::AuctionCurrency::unreserve(&winner, auction.best_price); | ^^^^^^^ help: change this to: `winner` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait --> frame/rws/src/lib.rs:325:54 | 325 | T::AuctionCurrency::reserve(&sender, amount.clone())?; | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/rws/src/lib.rs:418:26 | 418 | #[pallet::weight(100_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/rws/src/lib.rs:390:26 | 390 | #[pallet::weight(100_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/rws/src/lib.rs:371:26 | 371 | #[pallet::weight(100_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/rws/src/lib.rs:349:26 | 349 | #[pallet::weight(100_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/rws/src/lib.rs:306:26 | 306 | #[pallet::weight(100_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_5::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/rws/src/lib.rs:419:16 | 419 | pub fn start_auction( | ^^^^^^^^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_4::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/rws/src/lib.rs:391:16 | 391 | pub fn set_subscription( | ^^^^^^^^^^^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_3::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/rws/src/lib.rs:372:16 | 372 | pub fn set_oracle( | ^^^^^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_2::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/rws/src/lib.rs:350:16 | 350 | pub fn set_devices( | ^^^^^^^^^^^

warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`: It is deprecated to use implicit call indices. Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/12891> <https://github.com/paritytech/substrate/pull/11381> --> frame/rws/src/lib.rs:307:16 | 307 | pub fn bid( | ^^^

warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>` --> frame/liability/src/lib.rs:147:24 | 147 | pub fn finalize(origin: OriginFor<T>, report: ReportFor<T>) -> DispatchResultWithPostInfo { | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/liability/src/lib.rs:119:22 | 119 | pub fn create(origin: OriginFor<T>, agreement: T::Agreement) -> DispatchResultWithPostInfo { | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: this let-binding has unit value --> frame/liability/src/lib.rs:145:26 | 145 | #[pallet::weight(200_000)] | ^^^^^^^ help: omit the `let` binding: `200_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

warning: this let-binding has unit value --> frame/liability/src/lib.rs:117:26 | 117 | #[pallet::weight(200_000)] | ^^^^^^^ help: omit the `let` binding: `200_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default

warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/liability/src/lib.rs:145:26 | 145 | #[pallet::weight(200_000)] | ^^^^^^^

warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/liability/src/lib.rs:117:26 | 117 | #[pallet::weight(200_000)] | ^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: this `else { if .. }` block can be collapsed --> frame/liability/src/signed.rs:76:16 | 76 | } else { | ________________^ 77 | | if C::unreserve(&self.promisee, self.economics.price) == self.economics.price { 78 | | Ok(()) 79 | | } else { ... | 82 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 76 ~ } else if C::unreserve(&self.promisee, self.economics.price) == self.economics.price { 77 + Ok(()) 78 + } else { 79 + Err("reserved less than expected")? 80 + } |

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/launch/src/lib.rs:60:22 | 60 | pub fn launch( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>` --> frame/launch/src/lib.rs:60:22 | 60 | pub fn launch( | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: this let-binding has unit value --> frame/launch/src/lib.rs:58:26 | 58 | #[pallet::weight(500_000)] | ^^^^^^^ help: omit the `let` binding: `500_000;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default

warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`: It is deprecated to use hard-coded constant as call weight. Please instead benchmark all calls or put the pallet into `dev` mode. For more info see: <https://github.com/paritytech/substrate/pull/13798> --> frame/launch/src/lib.rs:58:26 | 58 | #[pallet::weight(500_000)] | ^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/datalog/src/lib.rs:131:21 | 131 | pub fn erase(origin: OriginFor<T>) -> DispatchResultWithPostInfo { | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `frame_support::sp_runtime::DispatchErrorWithPostInfo<frame_support::dispatch::PostDispatchInfo>` --> frame/datalog/src/lib.rs:131:21 | 131 | pub fn erase(origin: OriginFor<T>) -> DispatchResultWithPostInfo { | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `frame_support::dispatch::PostDispatchInfo` --> frame/datalog/src/lib.rs:108:22 | 108 | pub fn record(origin: OriginFor<T>, record: T::Record) -> DispatchResultWithPostInfo { | ^ help: consider removing | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion