Skip to content

Source Instagram: Remove Deprecated Metrics #55860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 7, 2025
Merged

Source Instagram: Remove Deprecated Metrics #55860

merged 16 commits into from
Apr 7, 2025

Conversation

topefolorunso
Copy link
Collaborator

@vercel Vercel
Copy link

vercel bot commented Mar 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 4:53pm

@topefolorunso topefolorunso changed the title remove depreacted metrics Source Instagram: Remove Deprecated Metrics Mar 20, 2025
@DanyloGL
Copy link
Collaborator

@topefolorunso as we are changing schema (removing fields) it's a breaking chnage. So it should be noted in metadata and migration guide also should be added.
cc @natikgadzhi

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Mar 23, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (eb0e405)

@topefolorunso
Copy link
Collaborator Author

All green here @DanyloGL

@DanyloGL
Copy link
Collaborator

@topefolorunso, thanks! Now it looks good.
@maxi297 regression test looks good, as it's certified connector, could you please review this PR and approve?

@DanyloGL DanyloGL requested a review from maxi297 March 24, 2025 14:24
maxi297
maxi297 reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see impressions under StoryInsights. Should this be cleaned as well?

@DanyloGL
Copy link
Collaborator

I still see impressions under StoryInsights. Should this be cleaned as well?

I think you are correct. Since it's based on MediaInsights stream, impressions metric should be also removed from StoryInsights.
@topefolorunso, could you please make these changes?
Here is working link for Graph changelog.

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Mar 31, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (62b9e28)

@topefolorunso
Copy link
Collaborator Author

all good here @DanyloGL

@topefolorunso topefolorunso requested a review from maxi297 March 31, 2025 19:09
maxi297
maxi297 approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the examples in conftest.py still relies on impression. Should we change that? Apart from that, I'm good with this change

@natikgadzhi
Copy link
Contributor

@topefolorunso @DanyloGL let's get this merged in, I'd like to not think about it beyond today.

DanyloGL
DanyloGL approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@DanyloGL DanyloGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natikgadzhi fixed, regression looks good. Can be merged.

@DanyloGL DanyloGL merged commit 069f56e into master Apr 7, 2025
28 of 29 checks passed
@DanyloGL DanyloGL deleted the tope/instagram/metrics-deprecation branch April 7, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxi297 maxi297 maxi297 approved these changes

@DanyloGL DanyloGL DanyloGL approved these changes

@natikgadzhi natikgadzhi Awaiting requested review from natikgadzhi

Assignees
No one assigned
Labels
connectors/source/instagram
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@topefolorunso @DanyloGL @natikgadzhi @maxi297 @octavia-squidington-iii