Skip to content

Source HubSpot: Migrate streams from deprecated V1 Contact Lists API to V3 Lists API before 5/30/2025 #56393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Source HubSpot: Migrate streams from deprecated V1 Contact Lists API to V3 Lists API before 5/30/2025 #56393

wants to merge 14 commits into from

Conversation

topefolorunso
Copy link
Collaborator

@topefolorunso topefolorunso requested a review from a team as a code owner March 25, 2025 17:33
@vercel Vercel
Copy link

vercel bot commented Mar 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 5:48pm

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Mar 25, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (ddab8e0)

@DanyloGL
Copy link
Collaborator

@topefolorunso,hi! Please fix unit tests. Also contact_lists, contacts_list_memberships streams do not retrieve records.

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Mar 31, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (0726a34)

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Mar 31, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (40d07e1)

@topefolorunso
Copy link
Collaborator Author

Tests passing here @DanyloGL. Please review.

@DanyloGL
Copy link
Collaborator

DanyloGL commented Apr 4, 2025

@topefolorunso, it's hard to find good connection with needed stream but tests showed that at least contacts_list_memberships stream returns much more data. It looks like it doesn't work with state and retrieves all records.

stream                           |      control record count    |     target record count     | 
contacts_list_memberships        |             1                |             90944           |

@topefolorunso
Copy link
Collaborator Author

@DanyloGL This may be due to the stream state used in testing. It should be in the format "YYYY-MM-DDTHH:mm:ss.SSS[Z]" not timestamp

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi Awaiting requested review from natikgadzhi

@DanyloGL DanyloGL Awaiting requested review from DanyloGL

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
connectors/source/hubspot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@topefolorunso @DanyloGL @octavia-squidington-iii