chore(directives): deprecate messageFromSteps
#3560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hidde Beydals <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
krancour
approved these changes
Feb 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3560 +/- ##
=======================================
Coverage 52.64% 52.64%
=======================================
Files 296 296
Lines 26875 26875
=======================================
Hits 14149 14149
Misses 11952 11952
Partials 774 774 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
Signed-off-by: Hidde Beydals <[email protected]> (cherry picked from commit 58217bf)
|
Successfully created backport PR for |
hiddeco
added a commit
that referenced
this pull request
Feb 25, 2025
Signed-off-by: Hidde Beydals <[email protected]> (cherry picked from commit 58217bf)
|
We will need to make sure we include a message about this depreciation in the release notes as well. Maybe it was already done, and I missed it, if so, my apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messageFromStepsof thegit-commitstep as deprecated and schedules it for removal inv1.5.0.The field was overlooked when we deprecated the other
<thing>FromStepfields. Likewise functionally can be achieved using expressions and a multiline message, refer to the tip in this section for more information.