Fix two issues affecting webseeds #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmcgovern
commented
Jul 31, 2024
src/MonoTorrent.Client/MonoTorrent.Client/PeerId.PieceRequester.cs
Outdated
Show resolved
Hide resolved
alanmcgovern
commented
Jul 31, 2024
src/MonoTorrent.Client/MonoTorrent.Connections/HttpPeerConnection.cs
Outdated
Show resolved
Hide resolved
alanmcgovern
commented
Jul 31, 2024
src/MonoTorrent.PiecePicking/MonoTorrent.PiecePicking/StandardPieceRequester.cs
Show resolved
Hide resolved
borigas
reviewed
Jul 31, 2024
src/MonoTorrent.Client/MonoTorrent.Connections/HttpPeerConnection.cs
Outdated
Show resolved
Hide resolved
alanmcgovern
force-pushed
the
fix-webseed-handling-of-padding
branch
from
4a8d703 to
5f06455
Compare
alanmcgovern
commented
Aug 2, 2024
src/Tests/Tests.MonoTorrent.PiecePicking/StandardPickerTests.cs
Outdated
Show resolved
Hide resolved
1) Ensure web requests request data in-order by fixing the piecepicker to correctly use 'CanRequestMorePieces' 2) Fix a bug in the handling of padding files. A request for some data from a webseed needs to take padding files into account in all cases. A request can begin or end inside padding, it can also begin/end in regular files while optionally crossing one stretch of padding. This means the existing logic to insert synethic requests to the padding file are broken in a number of cases.
alanmcgovern
force-pushed
the
fix-webseed-handling-of-padding
branch
from
6ff5843 to
3fbf9be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure web requests request data in-order by fixing the piecepicker
to correctly use 'CanRequestMorePieces'
Fix a bug in the handling of padding files. A request for some data
from a webseed needs to take padding files into account in all cases.
A request can begin or end inside padding, it can also begin/end in
regular files while optionally crossing one stretch of padding. This
means the existing logic to insert synethic requests to the padding
file are broken in a number of cases.