Skip to content

feat: enable src directory #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2020
Merged

feat: enable src directory #13

merged 1 commit into from
Nov 6, 2020

Conversation

jackjdleslie
Copy link

@jackjdleslie jackjdleslie commented Nov 6, 2020 •
edited
Loading

Issue

#12

Context

See https://nextjs.org/docs/advanced-features/src-directory

Changes

  • If a project contains /src/pages then change the srcDir to /src, otherwise default to /

Considerations

  • Need to add either tests or update one of/all of the examples
  • Need to update documentation

@jackjdleslie jackjdleslie requested a review from ije as a code owner November 6, 2020 23:34
@vercel
Copy link

vercel bot commented Nov 6, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/postui/alephjs-hello-world/ea7ltosqd
✅ Preview: https://alephjs-hello-world-git-feat-src-dir-choice.postui.vercel.app

shadowtime2000
shadowtime2000 approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@shadowtime2000 shadowtime2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ije
Copy link
Member

ije commented Nov 6, 2020

LGTM; thanks!

@ije ije merged commit e06e9af into alephjs:master Nov 6, 2020
ije
ije reviewed Nov 6, 2020
View reviewed changes
Copy link
Member

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackjdleslie jackjdleslie deleted the feat/src-dir-choice branch November 7, 2020 00:24
mohsenkhanpour pushed a commit to mohsenkhanpour/aleph.js that referenced this pull request Jan 29, 2021
Merge pull request alephjs#13 from bennettdams/patch-1
1fc3088 
docs: Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ije ije ije left review comments

@shadowtime2000 shadowtime2000 shadowtime2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackjdleslie @ije @shadowtime2000