-
Notifications
You must be signed in to change notification settings - Fork 8.1k
[Bug] grpc adapter-Tracer.trace() can't success #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
area/integrations
Issues or PRs related to integrations with open-source components
good first issue
Good for newcomers
kind/bug
Category issues or prs related to bug.
Milestone
Comments
and i think shouldn't call method |
Hi, thanks for reporting. This is the legacy code before Sentinel asynchronous entry support was introduced. So now we can refactor this to work correctly. Would you like to contribute a PR? :) |
@sczyh30 ok,i'm pleased to do it. I'll give it a try |
CodingSinger
added a commit
to CodingSinger/Sentinel
that referenced
this issue
Dec 7, 2018
CodingSinger
added a commit
to CodingSinger/Sentinel
that referenced
this issue
Dec 7, 2018
CodingSinger
added a commit
to CodingSinger/Sentinel
that referenced
this issue
Dec 7, 2018
CodingSinger
added a commit
to CodingSinger/Sentinel
that referenced
this issue
Dec 7, 2018
CodingSinger
added a commit
to CodingSinger/Sentinel
that referenced
this issue
Dec 7, 2018
CodingSinger
added a commit
to CodingSinger/Sentinel
that referenced
this issue
Dec 7, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/integrations
Issues or PRs related to integrations with open-source components
good first issue
Good for newcomers
kind/bug
Category issues or prs related to bug.
Issue Description
Here is code url:
code
the interceptor's(Server or Client) interceptCall method and the Listener method may run on different Thread, So,Tracer.trace(throwable) may not success if current Thread don't have the Context. I think here is should use
AsyncEntry
and callDescribe what happened (or what feature you want)
The text was updated successfully, but these errors were encountered: