-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Support Etcd datasource #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Etcd datasource #1018
Conversation
using the LongAdder rather than AtomicInteger to Provides better performance
merge master
…perties directory
merge online
…cator to load log config
merge onlie
merge online
This reverts commit d401c2f
Codecov Report
@@ Coverage Diff @@
## master #1018 +/- ##
===========================================
- Coverage 42.72% 42.43% -0.3%
- Complexity 1473 1476 +3
===========================================
Files 317 319 +2
Lines 9280 9346 +66
Branches 1267 1274 +7
===========================================
+ Hits 3965 3966 +1
- Misses 4825 4891 +66
+ Partials 490 489 -1
Continue to review full report at Codecov.
|
* @author lianglin | ||
* @since 1.7.0 | ||
*/ | ||
@Ignore(value = "Before run this test, you need to set up your etcd server.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any embedded etcd server for unit test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is none, the java version embedded etcd server I don't found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll test this in local these days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any progress?
> Note: It needs to update JDK version to JDK8 | ||
|
||
|
||
We've also provided an example: [sentinel-demo-etcd-datasource]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add the expected URL for the demo :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing! |
[RIP-65] Delete chinese period in CLITools.md file
Describe what this PR does / why we need it
Function expand, Add DataSource integration for etcd.
Does this pull request fix one issue?
Fixes #30
Describe how you did it
Through Jetcd Client https://mvnrepository.com/artifact/io.etcd/jetcd-core
Make sentinel enable communication with etcd server.
Using
EtcdConfig.java
to integration Sentinel Config Load mechanism.So that the Etcd Connect Properties can Config by properies file rather than
hard code in Code.
Through Jetcd watcher listening mechanism to implemnt rule dynamic update function.
Describe how to verify it
run test cases and demo
Special notes for reviews
The Jetcd need to run JDK8 env.