Skip to content

Add support for resource classification and polish adapters #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2019

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Nov 6, 2019

Describe what this PR does / why we need it

Add support for resource classification (e.g. RPC, Web) in SphU, ResourceWrapper and metric logs to make it convenient to identify which kind of resources are blocked frequently. All adapter modules are polished with the respective resource type.

Does this pull request fix one issue?

NONE

Describe how you did it

  • Add resourceType field in SphU, ResourceWrapper and ClusterNode. Add an extra field in the metric log.
  • Polish all adapter modules with the respective resource classification.
  • Improve CommonFilter of Web servlet filter: unify the urlEntry and httpMethodUrlEntry as one entry.

Describe how to verify it

Run the test cases and demo, then see the metric log.

Special notes for reviews

This PR contains a few changes (method name changes).

@sczyh30 sczyh30 added the kind/feature Category issues or prs related to feature request. label Nov 6, 2019
@sczyh30 sczyh30 added this to the 1.7.0 milestone Nov 6, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sczyh30 sczyh30 merged commit d38d548 into alibaba:master Nov 6, 2019
@sczyh30 sczyh30 deleted the feature/resource-classify branch November 6, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant