-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Upgrade Dubbo version in sentinel-demo-dubbo #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sczyh30 can you help me review |
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
============================================
+ Coverage 37.69% 38.25% +0.55%
- Complexity 981 992 +11
============================================
Files 235 235
Lines 7409 7409
Branches 1016 1016
============================================
+ Hits 2793 2834 +41
+ Misses 4254 4204 -50
- Partials 362 371 +9
Continue to review full report at Codecov.
|
Hi, could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=436 |
OK,3q |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing! |
dubbo version change ,old dubbo demo can't import DubboComponentScan on dubbo 2.6.2
I change the version to dubbo 2.6.5