Skip to content

Upgrade Dubbo version in sentinel-demo-dubbo #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

Leishunyu
Copy link
Contributor

dubbo version change ,old dubbo demo can't import DubboComponentScan on dubbo 2.6.2
I change the version to dubbo 2.6.5

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2019

CLA assistant check
All committers have signed the CLA.

@Leishunyu
Copy link
Contributor Author

@sczyh30 can you help me review

@codecov-io
Copy link

Codecov Report

Merging #436 into master will increase coverage by 0.55%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #436      +/-   ##
============================================
+ Coverage     37.69%   38.25%   +0.55%     
- Complexity      981      992      +11     
============================================
  Files           235      235              
  Lines          7409     7409              
  Branches       1016     1016              
============================================
+ Hits           2793     2834      +41     
+ Misses         4254     4204      -50     
- Partials        362      371       +9
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/LeapArray.java 68.35% <0%> (+6.32%) 24% <0%> (+2%) ⬆️
...a/csp/sentinel/slots/statistic/base/LongAdder.java 31.91% <0%> (+14.89%) 10% <0%> (+6%) ⬆️
...a/csp/sentinel/slots/statistic/base/Striped64.java 56.25% <0%> (+30.2%) 8% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a5225...7bf35fd. Read the comment docs.

@sczyh30
Copy link
Member

sczyh30 commented Jan 21, 2019

Hi, could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=436

@sczyh30 sczyh30 added the to-review To review label Jan 21, 2019
@sczyh30 sczyh30 changed the title change dubbo demo version Upgrade Dubbo version in sentinel-demo-dubbo Jan 21, 2019
@Leishunyu
Copy link
Contributor Author

Hi, could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=436

OK,3q

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 70a3144 into alibaba:master Jan 21, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 21, 2019

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants