-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix unstable test cases in OccupiableBucketLeapArrayTest #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
============================================
+ Coverage 40.8% 40.84% +0.03%
- Complexity 1215 1217 +2
============================================
Files 267 267
Lines 7911 7911
Branches 1072 1072
============================================
+ Hits 3228 3231 +3
+ Misses 4289 4288 -1
+ Partials 394 392 -2
Continue to review full report at Codecov.
|
Hi, thanks for contributing. Please make sure the email of your commits matches your GitHub email. 感谢贡献,请将 commit 对应的 email 调整成与 GitHub 的 email 相匹配。 |
...n/java/com/alibaba/csp/sentinel/slots/statistic/metric/occupy/OccupiableBucketLeapArray.java
Outdated
Show resolved
Hide resolved
f4d9227
to
222fe15
Compare
@sczyh30 Is there anything else need improve ? |
Since the long currentTime = System.currentTimeMillis();
setCurrentMillis(currentTime); Or the |
@sczyh30 Thank you for your remind, I've modified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing! |
Describe what this PR does / why we need it
Fix #685
Does this pull request fix one issue?
Describe how you did it
Pls see this blog for analysis: https://www.yuque.com/zhaixiaoxiang/cwrx8f/zzy18c
Describe how to verify it
Execute this test case many times to ensure it, because the BUG would happen by chance.
Special notes for reviews