[Flink] Introduce source deserializer #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
polyzos
requested review from
Copilot and
wuchong
and removed request for
Copilot
|
@wuchong PTAL |
wuchong
reviewed
Mar 27, 2025
fluss-flink/fluss-flink-common/src/test/java/com/alibaba/fluss/flink/helper/Order.java
Outdated
Show resolved
Hide resolved
fluss-flink/fluss-flink-common/src/test/java/com/alibaba/fluss/flink/helper/Order.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/com/alibaba/fluss/flink/source/deserializer/FlussRowDataDeserializer.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/alibaba/fluss/flink/source/deserializer/FlussDeserializationSchemaTest.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/alibaba/fluss/flink/source/deserializer/FlussDeserializationSchema.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/com/alibaba/fluss/flink/source/deserializer/FlussStringDeserializer.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/alibaba/fluss/flink/source/deserializer/FlussDeserializationSchema.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/com/alibaba/fluss/flink/source/deserializer/FlussRowDataDeserializer.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/com/alibaba/fluss/flink/source/deserializer/FlussStringDeserializer.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/com/alibaba/fluss/flink/source/deserializer/FlussRowDataDeserializer.java
Outdated
Show resolved
Hide resolved
|
@wuchong Thank you for your comments.. I addressed them all, so PTAL and let me know if I missed anything. |
wuchong
changed the title
wuchong
reviewed
Mar 27, 2025
.../src/main/java/com/alibaba/fluss/flink/source/deserializer/RowDataDeserializationSchema.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/alibaba/fluss/flink/source/deserializer/FlussDeserializationSchemaTest.java
Show resolved
Hide resolved
...rc/test/java/com/alibaba/fluss/flink/source/deserializer/FlussDeserializationSchemaTest.java
Show resolved
Hide resolved
...rc/test/java/com/alibaba/fluss/flink/source/deserializer/FlussDeserializationSchemaTest.java
Outdated
Show resolved
Hide resolved
...mmon/src/test/java/com/alibaba/fluss/flink/source/deserializer/FlussRowDeserializerTest.java
Outdated
Show resolved
Hide resolved
...mmon/src/test/java/com/alibaba/fluss/flink/source/deserializer/FlussRowDeserializerTest.java
Outdated
Show resolved
Hide resolved
...mmon/src/test/java/com/alibaba/fluss/flink/source/deserializer/FlussRowDeserializerTest.java
Outdated
Show resolved
Hide resolved
...mmon/src/test/java/com/alibaba/fluss/flink/source/deserializer/FlussRowDeserializerTest.java
Outdated
Show resolved
Hide resolved
...mmon/src/test/java/com/alibaba/fluss/flink/source/deserializer/FlussRowDeserializerTest.java
Outdated
Show resolved
Hide resolved
...mmon/src/test/java/com/alibaba/fluss/flink/source/deserializer/FlussRowDeserializerTest.java
Outdated
Show resolved
Hide resolved
|
Thanks @polyzos for the updates, I think this PR is very close to being ready for merge. I left some minor comments. |
|
@wuchong comments addressed.. let me know if there is anything else that requires attention |
wuchong
reviewed
Mar 29, 2025
.../src/main/java/com/alibaba/fluss/flink/source/deserializer/RowDataDeserializationSchema.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/alibaba/fluss/flink/source/deserializer/RowDataDeserializationSchema.java
Outdated
Show resolved
Hide resolved
|
@polyzos I appended a commit to polish the code and address the comment I left above. Will merge this once CI is passed... |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces Source Deserializer along with custom implementations for
StringandRowDatato be used for testing as well as to be exposed to users so they can get started quickly.