Hello world #32
Hello world #32
Conversation
|
put all the tf files into a terraform folder, to keep them separated from the rest of files |
|
do a 'terraform fmt' to properly format the tf files |
examples/sample_01/main.tf
Outdated
| @@ -0,0 +1,92 @@ | |||
| provider "google" { | |||
| credentials = file(var.credentials_file) | |||
There was a problem hiding this comment.
do not specify the credentials here, use the application default.
https://cloud.google.com/sdk/gcloud/reference/auth/application-default/login
It is is much safer this way
examples/sample_01/main.tf
Outdated
| @@ -0,0 +1,92 @@ | |||
| provider "google" { | |||
| credentials = file(var.credentials_file) | |||
| project = var.project | |||
There was a problem hiding this comment.
it is better if you specify these parameters on the resources explicitly than here.
This can lead to confusing errors, if you work in an environment with multiple projects and locations
examples/sample_01/main.tf
Outdated
| } | ||
|
|
||
| resource "google_bigquery_dataset" "dataset" { | ||
| dataset_id = "example_dataset" |
examples/sample_01/main.tf
Outdated
|
|
||
| resource "google_bigquery_dataset" "dataset" { | ||
| dataset_id = "example_dataset" | ||
| friendly_name = "test" |
There was a problem hiding this comment.
this is an optional parameter so either fill it with meaningful value or remove it.
This is just a temporary dataset, so this is not really needed
examples/sample_01/main.tf
Outdated
| resource "google_bigquery_dataset" "dataset" { | ||
| dataset_id = "example_dataset" | ||
| friendly_name = "test" | ||
| description = "This is a test description" |
There was a problem hiding this comment.
this is an optional parameter so either fill it with meaningful value or remove it.
This is just a temporary dataset, so this is not really needed
examples/sample_01/main.tf
Outdated
| schema = <<EOF | ||
| [ | ||
| { | ||
| "name": "ID", |
There was a problem hiding this comment.
be consistent either use uppercase everywhere or lowercase everywhere for the columnnames
examples/sample_01/main.tf
Outdated
| dataset_id = google_bigquery_dataset.dataset.dataset_id | ||
| table_id = "car_output" | ||
|
|
||
| time_partitioning { |
There was a problem hiding this comment.
you do not need this here, this is just an ephemeral small table
examples/sample_01/main.tf
Outdated
| time_partitioning { | ||
| type = "DAY" | ||
| } | ||
| labels = { |
There was a problem hiding this comment.
this is an optional parameter so either fill it with meaningful value or remove it.
This is just a temporary dataset, so this is not really needed
examples/sample_01/main.tf
Outdated
| { | ||
| "name": "ID", | ||
| "type": "INTEGER", | ||
| "mode": "REQUIRED", |
There was a problem hiding this comment.
what is the transformation you are planning to execute, why is the schema of the table the same?
examples/sample_01/terraform.tfvars
Outdated
| @@ -0,0 +1,2 @@ | |||
| project = "koller-dani-sandbox" | |||
| credentials_file = "C:/Users/kollerdani/Desktop/koller-dani-sandbox-10e37a32eb02.json" | |||
There was a problem hiding this comment.
in general, you should never put anything into the code repository that only works in your local environment.
|
add tf specific gitignore |
examples/sample_01/Terraform/main.tf
Outdated
| @@ -0,0 +1,72 @@ | |||
| provider "google" { | |||
| region = "europe-west1" | |||
There was a problem hiding this comment.
do not define region and zone here
| @@ -0,0 +1 @@ | |||
| project = "koller-dani-sandbox" | |||
There was a problem hiding this comment.
do not add this to the repo, just keep it locally
.gitignore
Outdated
|
|
||
| *.tfstate | ||
| *.tfstate.* | ||
| *.tfvars |
There was a problem hiding this comment.
| "zh:a853f1a1e9f5ac261fd9a02d869ce7da16917fdd16464dabf2200e2ccd04fba9", | ||
| "zh:aba631b9db47cc34857c25459475f17d939a46022f886e396a8254588f720c58", | ||
| "zh:ac461358984ba480b4fef1d2be3538d9714aa8814a6f420e1e954227054a14a4", | ||
| "zh:ade64689485fc28b6aa0c36861c6c9c66b5d7a8e7282739ecf97c7791b973312", |
There was a problem hiding this comment.
remove the exe below from git. This is downloaded automatically during the tf init, so not needed in version control
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 13 files reviewed, 19 unresolved discussions (waiting on @csabakassai, @kollerdaniel, and @nbali)
a discussion (no related file):
asdasd
There was a problem hiding this comment.
Reviewed 1 of 7 files at r2, 1 of 8 files at r6, 3 of 3 files at r7, 4 of 4 files at r12, 1 of 1 files at r13, 1 of 2 files at r15, 2 of 2 files at r16, all commit messages.
Reviewable status: all files reviewed, 18 unresolved discussions (waiting on @kollerdaniel)
There was a problem hiding this comment.
Reviewable status: all files reviewed (commit messages unreviewed), 18 unresolved discussions (waiting on @kollerdaniel)
This change is