[no ticket][risk=low] update tables to latest #4
Conversation
jaycarlton
changed the title
| project = var.project_id | ||
| region = var.region | ||
| zone = var.zone | ||
| project = "all-of-us-workbench-test" |
There was a problem hiding this comment.
Was this for testing? Revert?
There was a problem hiding this comment.
You need it for terraform import to work in 0.13. Otherwise it tells you it doesn't know how to find the provider. Hopefully it can be removed soon.
There was a problem hiding this comment.
I don't follow, how does this get overridden when we use this module for an environment that is not all-of-us-workbench-test ? If it's not getting overridden, and the module still works properly for other projects, what is this parameter actually doing then?
There was a problem hiding this comment.
Good point. I think the right way to do it is to specify the provider only at the highest level.
|
|
||
| # TODO(jaycarlton) codegen this top-level variables as the union | ||
| # of all modules' variables files. | ||
| # List of objects whose values correspond to the google_monitoring_notification_channel |
There was a problem hiding this comment.
This stuff doesn't look relevant to the PR - remove? Minimally, should remove commented out code
There was a problem hiding this comment.
yeah, thought I I needed it, but I guess not.
Bring all configs up-to-date, which is still slightly behind, but a good stopping point. We should be able to add a new column now.