Skip to content

fixing an issue where using f-strings uses the enum name instead of t… #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2023
Merged

fixing an issue where using f-strings uses the enum name instead of t… #378

merged 1 commit into from
Nov 17, 2023

Conversation

gageorsburn
Copy link
Contributor

…he enum value

exception hit in prod:
requests.exceptions.MissingSchema: Invalid URL 'BaseURL.BROKER_PRODUCTION/v1/accounts/XXXX-69da-44c2-bf62-37b29a9a2063/documents/XXXX-af19-45c1-8ad5-4313582caab0/download': No scheme supplied. Perhaps you meant https://BaseURL.BROKER_PRODUCTION/v1/accounts/XXXX-69da-44c2-bf62-37b29a9a2063/documents/XXXX-af19-45c1-8ad5-4313582caab0/download?

the behavior is like this:

(Pdb) self._base_url + "foo"
'https://broker-api.alpaca.marketsfoo/'
(Pdb) f"{self._base_url}"
'BaseURL.BROKER_PRODUCTION'

@gageorsburn
Copy link
Contributor Author

@hiohiohio any chance I could get a review :)?

hiohiohio
hiohiohio approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great catch! Thank you for the mention!

@hiohiohio hiohiohio merged commit 6f10582 into alpacahq:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiohiohio hiohiohio hiohiohio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gageorsburn @hiohiohio