Skip to content

feat: Add DELAYED_SIP for DataFeed #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

feat: Add DELAYED_SIP for DataFeed #591

merged 1 commit into from
Apr 28, 2025

Conversation

hiohiohio
Copy link
Contributor

closes #571

Context:

  • The latest data API endpoints of MarketData API support delayed_sip for feed parameter

Changes:

  • add DELAYED_SIP for DataFeed enum

@hiohiohio hiohiohio requested review from alanvoss and gnvk April 28, 2025 04:33
gnvk
gnvk approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@gnvk gnvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiohiohio hiohiohio merged commit c373ff2 into master Apr 28, 2025
13 checks passed
@hiohiohio hiohiohio deleted the feature-add-delayed-sip branch April 28, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnvk gnvk gnvk approved these changes

@alanvoss alanvoss Awaiting requested review from alanvoss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the delayed_sip feed
2 participants
@hiohiohio @gnvk