fix: ensure solid-js
is included in pre-bundle
#12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a necessary component of fixing solidjs/solid-start#4.
In a standard, single project repo, running the vite dev server with this plugin (via
solid-start
) results in three dependencies being pre-bundled:solid-js/web
,solid-js
, andsolid-js/dev
even though this plugin only specifiesoptimizeDeps.include: ['solid-js/dev', 'solid-js/web']
.However, in a monorepo setup only two dependencies are pre-bundled:
solid-js/web
andsolid-js/dev
. This results in the following error during development (I never tested production) and the development build is never servedBy adding
solid-js
tooptimizeDeps.include
, theYou appear to have multiple instances of Solid...
errors are eliminated and, in my testing, there appears to be no affect for single project repositories. I believe this PR is a necessary component of supporting monorepo development (the end user can also work around this issue by manually addingoptimizeDeps.include: ['solid-js']
to their localvite.config.ts
file, but this bakes monorepo support into the plugin itself).