Skip to content

docs: describe proper monorepo usage #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2021

Conversation

jorroll
Copy link
Contributor

@jorroll jorroll commented May 13, 2021

This PR, along with solidjs/vite-plugin-solid#12, fixes #4 .

@ryansolid
Copy link
Member

To be honest I sort of intend to change how to set the entry. Relying on /node_modules is super hacky. I was doing it for now but I expect this to change before even we reach beta. I can add this for now. But more than likely I will remove it in the next couple weeks.

@ryansolid ryansolid merged commit 38e9fcc into solidjs:main May 13, 2021
@jorroll
Copy link
Contributor Author

jorroll commented May 13, 2021

Makes sense

```
Copy link
Contributor

@devinrhode2 devinrhode2 Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5 (comment)

To be honest I sort of intend to change how to set the entry. Relying on /node_modules is super hacky. I was doing it for now but I expect this to change before even we reach beta. I can add this for now. But more than likely I will remove it in the next couple weeks.

I wish there was a "git blame" for the future, i.e. what commit changed this code next?

For now we'll check manually:

  1. Search docs (README.md) for "monorepo": https://github.com/solidjs/solid-start/blame/main/README.md

Conclusion: Monorepo docs are here: https://github.com/solidjs/solid-start#monorepo--projectjson-workspace-support :)

@devinrhode2
Copy link
Contributor

devinrhode2 commented Aug 1, 2023

Not really an issue with SolidStart, but I figured I'd cross-link an issue I'm having using SolidStart in an Nx monorepo here: nxext/nx-extensions#983

TL;DR: Vite is serving up the initial request for entry-client.tsx as un-transpiled source code (i.e. raw jsx, which browsers don't know how to parse)

@jorroll jorroll deleted the monorepo-docs branch August 1, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-solid does not support monorepo with yarn workspaces and hoisted deps
3 participants