Run tests using PHP 7.3 on Travis CI #1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3-for-travis * 'develop' of github.com:ampproject/amp-wp: Correct license in composer.json as GPL-2.0-or-later Consolidate translator comments for forgotten URLs string Drop unnecessary sanitize_hex_color() polyfill and rename amp-post-template-actions.php to amp-post-template-functions.php. Fix composer.json indentation. Ensure all dependencies are PHP 5.4 compatible. Ensure FasterImage allows to set its user agent. Eliminate PHP 5.3-compatibility workarounds for closures Eliminate PHP 5.3-specific testsuite Ensure that Travis will npm install and composer install for each build Restore linebreaks in readme.md Exclude patches from build Improve phpdoc; catch Exception from fetch_images; add todo Remove unnecessary support for argument when fetching image dimensions and deprecate it on the public method. Fix FunctionCallSignature for new WP code style Fix MultipleStatementAlignment in autoloader manifest Pull in FasterImage library via Composer and apply manual changes via patch file. Remove now unnecessary FastImage library. Update minimum required PHP version to 5.4.
westonruter
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if the tests pass with that change.
See #1813.