fix: guaranteed order of preprocessor execution #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
Can you add a changeset? |
jorenbroekema
approved these changes
Apr 16, 2025
dbanksdesign
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Having multiple preprocessors defined in the SD config, did not guarantee the execution of the preprocessors in the exact order, how they have been configured in the SD config.
Technical reason behind that is, that it has been looped over the properties of a JS object, which had the respective preprocessor functions connected to the preprocessor names as the object properties. As we all know Javascript has a flaw, when it comes to ordering in JS objects.
Therefore we now rely on the right order, by looping over the preprocessor names in the
appliedPreprocessorsarray parameter, which already has been available in thepreprocessfunction.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.