feat: Improve grype error handling #455
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devodev
force-pushed
the
pr/devodev/handle-fail-on-error
branch
from
9b8242e to
53fa032
Compare
Starting with Grype v0.92.0, we can correctly infer when an error returned from the CLI is for a failing severity from --fail-on. Adapt the command error handling to make it clear when the action cannot be certain of the error and emit warnings accordingly. Signed-off-by: Alexandre Barone <[email protected]>
devodev
force-pushed
the
pr/devodev/handle-fail-on-error
branch
from
53fa032 to
86b5f10
Compare
devodev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Grype v0.92.0, we can correctly infer when an error returned from the CLI is for a failing severity from
--fail-on(PR). Adapt the command error handling to make it clear when the action cannot be certain of the error and emit warnings accordingly.Also I've made sure to fail the action if severity cut off is disabled and an error occurs, which I think is the correct way to make sure errors are correctly surfaced?
I'd love to get more feedback on the overall error handling as well. More specifically, I've added warning logs with stdout/stderr when we can't correctly determine if an error is for a failing severity, otherwise I couldn't find a way to get to the the error without manually running the CLI. Does that make sense?
TODO: wait for Grype v0.92.0 release
Fixes: #390