Skip to content

REFACTOR: Configure layout #6287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

REFACTOR: Configure layout #6287

wants to merge 6 commits into from

Conversation

hui-zhou-a
Copy link
Contributor

  • Add comments in toml
  • Add test for batch mode

@hui-zhou-a hui-zhou-a requested a review from a team as a code owner June 20, 2025 06:46
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Jun 20, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (7fece27) to head (21dad36).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6287      +/-   ##
==========================================
- Coverage   85.28%   85.28%   -0.01%     
==========================================
  Files         173      173              
  Lines       65358    65331      -27     
==========================================
- Hits        55742    55718      -24     
+ Misses       9616     9613       -3
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SMoraisAnsys
SMoraisAnsys reviewed Jun 20, 2025
View reviewed changes
src/ansys/aedt/core/extensions/project/configure_layout.py
Comment on lines +429 to +430
ExtensionDataLoad.fpath_config = Path(config_file)
ExtensionDataLoad.working_directory = Path(working_directory)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hui-zhou-a Why are you working with ExtensionDataLoad in such a way instead of creating an instance and leveraging that instance ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMoraisAnsys class and instance work in the same way when only one instance is needed, which is the case. I found using class is easier.

src/ansys/aedt/core/extensions/project/resources/configure_layout/example_serdes.toml Outdated
Comment on lines 3 to 4
version = "2025.1" # Only applicable in batch mode
layout_file = "D:/_pycharm_project/example-data/pyaedt/edb/ANSYS_SVP_V1_1.aedb" # Source layout. Available formats are aedt and aedb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To help with user's reading, shouldn't we add the comments above the assignment ? For example

# Only applicable in batch mode
version = "2025.1"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hui-zhou-a @SMoraisAnsys @pyansys-ci-bot