refactor: static class attributes #4174
Open
+44
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpohekar
reviewed
Jun 17, 2025
prmukherj
commented
Jun 17, 2025
prmukherj
commented
Jun 17, 2025
seanpearsonuk
approved these changes
Jun 19, 2025
|
@prmukherj Have you verified that settings API docs are rendering correctly by running Nightly Dev Doc Build workflow using this branch ? |
I have run it: https://github.com/ansys/pyfluent/actions/runs/15754777339 Let's verify the results once it is generated. |
prmukherj
commented
Jun 20, 2025
| @@ -139,8 +150,12 @@ def _populate_rst_from_settings(rst_dir, cls, version): | |||
| r.write(f'{"="*(len(cls_orig_name))}\n\n') | |||
| deprecated = getattr(cls, "_deprecated_version", None) | |||
| if deprecated: | |||
| release_version = "20" + cls._deprecated_version.replace(".", "R") | |||
| r.write(f".. deprecated:: Ansys {release_version}\n\n") | |||
| if float(cls._deprecated_version) < 22.2: | |||
There was a problem hiding this comment.
Here if the deprecated version is less that 22.2, we provide the least version supported by pyfluent, i.e. 2022R2, as the versions before that are not supported by our FluentVersion enum,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor static class attributes access