Skip to content

fix: No warning for None values and remove a doc dependency #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Jun 20, 2025

  1. Remove tensorflow dependency as it is supported for Python version <= 3.10.
  2. quarto-cli works fine after updating ansys-sphinx-theme.
  3. Do not show a warning if graphics_drivers or ui_mode are None.

We will merge this PR before creating a release.

Earlier -

solver = launch_fluent(start_container=True, dry_run=True)
/home/hpohekar/pyfluent/src/ansys/fluent/core/launcher/launch_options.py:309: PyFluentUserWarning: User-specified value for graphics driver is ignored while launching Fluent without GUI or without graphics.
  warnings.warn(
pyfluent.launcher WARNING: Configuring Fluent container to mount to /home/hpohekar/pyfluent, with this path available as /home/container/workdir for the Fluent session running inside the container.

Now -

solver = launch_fluent(start_container=True, dry_run=True)
pyfluent.launcher WARNING: Configuring Fluent container to mount to /home/hpohekar/pyfluent, with this path available as /home/container/workdir for the Fluent session running inside the container.

@github-actions github-actions bot added maintenance General maintenance of the repo (libraries, cicd, etc) dependencies Related to dependencies bug Issue, problem or error in PyFluent labels Jun 20, 2025
@hpohekar hpohekar requested a review from raph-luc June 20, 2025 12:48


def test_no_warning_for_none_values(caplog):
driver = _get_graphics_driver(graphics_driver=None, ui_mode=None) # noqa: F841
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also work? Then don't need to add the flake disable directive

Suggested change
driver = _get_graphics_driver(graphics_driver=None, ui_mode=None) # noqa: F841
_get_graphics_driver(graphics_driver=None, ui_mode=None)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyFluent dependencies Related to dependencies maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting warning for user-specified values, when no user-specified values were set Couple of issues while installing doc dependencies locally
5 participants