Skip to content

fix: sourcemap issue #6807 #6827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025
Merged

fix: sourcemap issue #6807 #6827

merged 3 commits into from
May 7, 2025

Conversation

ianzone
Copy link
Contributor

@ianzone ianzone commented May 4, 2025

Checklist
  • npm test passes. jest 总是把我电脑搞崩,16GB 内存都不够跑的
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated 无需更新
Description of change

主要是删除 tsconfig 中的 sourceRoot,这样生成的 map 文件的 sources 数组会是["../src/xxx.ts"],从而能被 vite 正确加载

@ianzone ianzone mentioned this pull request May 4, 2025
4 tasks
@hustcc
Copy link
Member

hustcc commented May 6, 2025

@ianzone 把格式化相关的 diff 去掉吧,就合并掉了。

@coveralls
Copy link

coveralls commented May 6, 2025

Pull Request Test Coverage Report for Build 14874084757

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 86.663%

Files with Coverage Reduction New Missed Lines %
src/mark/wordCloud.ts 2 82.35%
Totals Coverage Status
Change from base Build 14727561907: -0.006%
Covered Lines: 10762
Relevant Lines: 12026

💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented May 7, 2025

还是保留 src 把,可能在某些环境,sourcemap 会依赖源码,见之前的 issue。

@hustcc hustcc merged commit d02d480 into antvis:v5 May 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants