-
Notifications
You must be signed in to change notification settings - Fork 3.8k
GH-46198: [Python] Remove deprecated PyExtensionType #46199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-46198: [Python] Remove deprecated PyExtensionType #46199
Conversation
Can you check if it breaks https://pypi.org/project/pyarrow-hotfix/ ? |
Yeah, it breaks it: >>> import pyarrow_hotfix
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/alenkafrim/Envs/pyarrow-dev/lib/python3.12/site-packages/pyarrow_hotfix/__init__.py", line 110, in <module>
install()
File "/Users/alenkafrim/Envs/pyarrow-dev/lib/python3.12/site-packages/pyarrow_hotfix/__init__.py", line 66, in install
pa.unregister_extension_type("arrow.py_extension_type")
File "pyarrow/types.pxi", line 2281, in pyarrow.lib.unregister_extension_type
check_status(UnregisterPyExtensionType(c_type_name))
File "pyarrow/error.pxi", line 92, in pyarrow.lib.check_status
raise convert_status(status)
pyarrow.lib.ArrowKeyError: No type extension with name arrow.py_extension_type found Should I propose an update in the pyarrow-hotfix repo |
@AlenkaF Yes, please do! |
@pitrou, I have submitted pitrou/pyarrow-hotfix#8 (tested locally with the changes in this PR and with pyarrow 19.0.0). |
In PyArrow version 21.0.0 `PyExtensionType` will be removed, see apache/arrow#46199. We need to update the checks in `__init__` so that the hotfix doesn't break with future pyarrow versions.
As pyarrow-hotfix update has been merged, this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove it from the docs?
arrow/docs/source/python/api/datatypes.rst
Line 134 in 594fc16
PyExtensionType |
@github-actions crossbow submit -g python |
Revision: b4b3728 Submitted crossbow builds: ursacomputing/crossbow @ actions-2813be5290 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AlenkaF
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 26170b4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
PyExtensionType
has been deprecated in #38608 and can now be removed.What changes are included in this PR?
PyExtensionType
functionality is removed from PyArrow code.Are these changes tested?
Existing tests should pass.
Are there any user-facing changes?
Deprecated classes are removed.