GH-46198: [Python] Remove deprecated PyExtensionType #46199
+7
−161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you check if it breaks https://pypi.org/project/pyarrow-hotfix/ ? |
|
Yeah, it breaks it: >>> import pyarrow_hotfix
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/alenkafrim/Envs/pyarrow-dev/lib/python3.12/site-packages/pyarrow_hotfix/__init__.py", line 110, in <module>
install()
File "/Users/alenkafrim/Envs/pyarrow-dev/lib/python3.12/site-packages/pyarrow_hotfix/__init__.py", line 66, in install
pa.unregister_extension_type("arrow.py_extension_type")
File "pyarrow/types.pxi", line 2281, in pyarrow.lib.unregister_extension_type
check_status(UnregisterPyExtensionType(c_type_name))
File "pyarrow/error.pxi", line 92, in pyarrow.lib.check_status
raise convert_status(status)
pyarrow.lib.ArrowKeyError: No type extension with name arrow.py_extension_type foundShould I propose an update in the pyarrow-hotfix repo |
|
@AlenkaF Yes, please do! |
|
@pitrou, I have submitted pitrou/pyarrow-hotfix#8 (tested locally with the changes in this PR and with pyarrow 19.0.0). |
pitrou
pushed a commit
to pitrou/pyarrow-hotfix
that referenced
this pull request
Apr 25, 2025
In PyArrow version 21.0.0 `PyExtensionType` will be removed, see apache/arrow#46199. We need to update the checks in `__init__` so that the hotfix doesn't break with future pyarrow versions.
|
As pyarrow-hotfix update has been merged, this PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
PyExtensionTypehas been deprecated in #38608 and can now be removed.What changes are included in this PR?
PyExtensionTypefunctionality is removed from PyArrow code.Are these changes tested?
Existing tests should pass.
Are there any user-facing changes?
Deprecated classes are removed.