Skip to content

Fix PostCommit TransformService Direct job #34375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

Amar3tto
Copy link
Collaborator

@Amar3tto Amar3tto commented Mar 21, 2025

Fixes #30960

Successful run: https://github.com/Amar3tto/beam/actions/runs/13992581500


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Amar3tto Amar3tto marked this pull request as draft March 21, 2025 13:13
@Amar3tto Amar3tto marked this pull request as ready for review March 21, 2025 15:08
@Amar3tto
Copy link
Collaborator Author

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Amar3tto Amar3tto requested a review from damccorm March 21, 2025 15:40
@damccorm damccorm merged commit 047f896 into apache:master Mar 21, 2025
91 checks passed
@Abacn
Copy link
Contributor

Abacn commented Mar 24, 2025

This was caused by #34073, specifically this line: https://github.com/apache/beam/pull/34073/files#diff-4d72b1d96a597dfd42528b37549162b5124462b5c8bf6655d9cef91d9b3c8ac7L58

cc: @robertwb in what scenario it needed to be localhost?

@robertwb
Copy link
Contributor

"[::]" was failing tests sometimes, perhaps do to inavailability (or flakiness) of ipv6?

@robertwb
Copy link
Contributor

0.0.0.0 might assume/require ipv4 though

prodriguezdefino pushed a commit to prodriguezdefino/beam-pabs that referenced this pull request Mar 26, 2025
* Fix address in expansion service

* Change address to 0.0.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The PostCommit TransformService Direct job is flaky
4 participants