-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Fix PostCommit TransformService Direct job #34375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
R: @damccorm |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
This was caused by #34073, specifically this line: https://github.com/apache/beam/pull/34073/files#diff-4d72b1d96a597dfd42528b37549162b5124462b5c8bf6655d9cef91d9b3c8ac7L58 cc: @robertwb in what scenario it needed to be localhost? |
"[::]" was failing tests sometimes, perhaps do to inavailability (or flakiness) of ipv6? |
0.0.0.0 might assume/require ipv4 though |
* Fix address in expansion service * Change address to 0.0.0.0
Fixes #30960
Successful run: https://github.com/Amar3tto/beam/actions/runs/13992581500
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.