feat: add SchemaProvider::table_type(table_name: &str) #16401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InformationSchemaConfig::make_tables only needs the TableType not the whole TableProvider, and the former may require an expensive catalog operation to construct and the latter may not. This allows avoiding `SELECT * FROM information_schema.tables` having to make 1 of those potentially expensive operations per table.
I looked around for some tests implementing this interface that I could extend, but didn't find any. I meant to ask earlier but forgot: is there anything like that? It would be a big help if I had some previous tests to take inspiration from. Failing that, I'll take a stab at it anyway :) Thanks! |
comphead
reviewed
Jun 15, 2025
| /// returns `None`. Implementations for which this operation is cheap but [Self::table] is | ||
| /// expensive can override this to improve operations that only need the type, e.g. | ||
| /// `SELECT * FROM information_schema.tables`. | ||
| async fn table_type(&self, name: &str) -> Result<Option<TableType>, DataFusionError> { |
There was a problem hiding this comment.
Suggested change
| async fn table_type(&self, name: &str) -> Result<Option<TableType>, DataFusionError> { | |
| async fn table_type(&self, name: &str) -> DataFusionResult<Option<TableType>> { |
comphead
reviewed
Jun 15, 2025
| /// expensive can override this to improve operations that only need the type, e.g. | ||
| /// `SELECT * FROM information_schema.tables`. | ||
| async fn table_type(&self, name: &str) -> Result<Option<TableType>, DataFusionError> { | ||
| self.table(name).await.map(|o| o.map(|t| t.table_type())) |
There was a problem hiding this comment.
is there any way to avoid nested map? perhaps flat_map or and_then ? would me more readable IMHO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InformationSchemaConfig::make_tables only needs the TableType not the whole TableProvider, and the former may require an expensive catalog operation to construct and the latter may not.
This allows avoiding
SELECT * FROM information_schema.tableshaving to make 1 of those potentially expensive operations per table.