[fix](function) JSON_EXTRACT_STRING should return NULL instead of the string 'null' when encountering a NULL value #51516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
PR approved by anyone and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 33838 ms |
TPC-DS: Total hot run time: 193101 ms |
ClickBench: Total hot run time: 29.22 s |
morningman
previously approved these changes
Jun 5, 2025
mrhhsg
dismissed stale reviews from eldenmoon, morningman, and HappenLee
via
62c2ab5
mrhhsg
force-pushed
the
fix_json_extract_string
branch
from
90dd2af to
62c2ab5
Compare
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 33946 ms |
TPC-DS: Total hot run time: 192988 ms |
… string 'null' when encountering a NULL value
mrhhsg
force-pushed
the
fix_json_extract_string
branch
from
62c2ab5 to
c78210d
Compare
|
run buildall |
TPC-H: Total hot run time: 33819 ms |
TPC-DS: Total hot run time: 185545 ms |
ClickBench: Total hot run time: 29.33 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
yiguolei
approved these changes
Jun 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2025
… string 'null' when encountering a NULL value (#51516) ### What problem does this PR solve? Previously, when JSON_EXTRACT_STRING encountered a NULL input value or path, it returned the string "null" instead of a proper SQL NULL value. This behavior could lead to incorrect query results and confusion in downstream processing that expects NULL to be represented as an actual null value rather than a literal string. This commit adjusts the logic to ensure that JSON_EXTRACT_STRING returns NULL in such cases, aligning with SQL semantics and improving compatibility with systems that rely on strict null-handling behavior.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2025
… string 'null' when encountering a NULL value (#51516) ### What problem does this PR solve? Previously, when JSON_EXTRACT_STRING encountered a NULL input value or path, it returned the string "null" instead of a proper SQL NULL value. This behavior could lead to incorrect query results and confusion in downstream processing that expects NULL to be represented as an actual null value rather than a literal string. This commit adjusts the logic to ensure that JSON_EXTRACT_STRING returns NULL in such cases, aligning with SQL semantics and improving compatibility with systems that rely on strict null-handling behavior.
dataroaring
pushed a commit
that referenced
this pull request
Jun 11, 2025
…stead of the string 'null' when encountering a NULL value #51516 (#51565) Cherry-picked from #51516 --------- Co-authored-by: Jerry Hu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Previously, when JSON_EXTRACT_STRING encountered a NULL input value or path, it returned the string "null" instead of a proper SQL NULL value. This behavior could lead to incorrect query results and confusion in downstream processing that expects NULL to be represented as an actual null value rather than a literal string.
This commit adjusts the logic to ensure that JSON_EXTRACT_STRING returns NULL in such cases, aligning with SQL semantics and improving compatibility with systems that rely on strict null-handling behavior.
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)