AWS: Close the S3SeekableInputStreamFactory before removing from cache #12891
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajdchak
reviewed
Apr 24, 2025
| } | ||
| } | ||
| } | ||
|
|
||
| public static void cleanupCache( | ||
| S3AsyncClient asyncClient, S3FileIOProperties s3FileIOProperties) { | ||
| STREAM_FACTORY_CACHE.invalidate(Pair.of(asyncClient, s3FileIOProperties)); |
There was a problem hiding this comment.
before invalidating the factories from the cache also we should close the factories.
There was a problem hiding this comment.
Actually, current removalListener implementation already handles this case. In Caffeine, 'invalidation' (manual removal by the caller) and 'eviction' (removal due to cache policy) are both treated as removals.
rajdchak
suggested changes
Apr 24, 2025
rajdchak
approved these changes
Apr 25, 2025
stubz151
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current integration with the S3 Analytics Accelerator Library ( #12299 ) is not closing the
S3SeekableInputStreamFactoryonS3FileIOclose. This PR incorporates that logic by closing it before removing from cache.