Flink: Backport add StreamingStartingStrategy.INCREMENTAL_FROM_LATEST_SNAPSHOT_EXCLUSIVE to Flink 1.19 #12899
Conversation
morhidi
force-pushed
the
latest-exclusive-1.19
branch
from
22e543f to
e400e38
Compare
|
cc @rodmeneses @mxm |
…_SNAPSHOT_EXCLUSIVE to Flink 1.19 backports apache#12839
morhidi
force-pushed
the
latest-exclusive-1.19
branch
from
e400e38 to
f3e8292
Compare
morhidi
changed the title
|
Hi, @mxm I have a small question regarding future backports. Since Flink 2.0 has been introduced, should we also prepare new backports for the 2.0 version going forward? |
|
@Guosmilesmile Absolutely, there was a bit of race condition with merging the original PR and the Flink 2.0 PR. Thanks for pointing that out! @morhidi Could you also include the Flink 2.0 changes in this PR? Normally, we merge to the latest Flink version first and then backport, but this is a special situation. |
|
@mxm Thank you very much for your quick response. Since 2.0 was just merged a few days ago, I also had the same confusion. Now I understand how to proceed in the future. Thank you very much! |
Flink 2.0 contains these changes already, only Flink 1.19 does not, so I we're good here |
|
@stevenzwu or @pvary could you please check and merge this backport? |
|
@morhidi: is this a clean backport? Please help future reviewers by starting if a backport is clean, or highlight the required changes. Thanks, Peter |
|
@morhidi @Guosmilesmile Indeed, 2.0 already contains this change. I rebased the Flink 2.0 PR (#12527) based on the Flink 1.20 code after the original PR to this backport (#12839) had been merged. So we're good for Flink 2.0. |
|
Discussed with @morhidi offline. Clean means, that there are no changes compared to the original PR. This backport is clean. |
backports #12839