Skip to content

Commit b4e75fb

Browse files
authored
HOTFIX: add SuppressWarnings to TieredStorageTestUtils (#19494)
We need add SuppressWarnings annotation, because `log.cleaner.enable` mark deprecated. Reviewers: PoAn Yang <[email protected]>, Kuan-Po Tseng <[email protected]>, TengYao Chi <[email protected]>, Chia-Ping Tsai <[email protected]>
1 parent 67fa365 commit b4e75fb

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.apache.kafka.server.log.remote.metadata.storage.TopicBasedRemoteLogMetadataManager;
2828
import org.apache.kafka.server.log.remote.metadata.storage.TopicBasedRemoteLogMetadataManagerConfig;
2929
import org.apache.kafka.server.log.remote.storage.LocalTieredStorage;
30+
import org.apache.kafka.storage.internals.log.CleanerConfig;
3031
import org.apache.kafka.tiered.storage.TieredStorageTestContext;
3132

3233
import org.junit.jupiter.api.Assertions;
@@ -53,7 +54,6 @@
5354
import static org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_LOG_STORAGE_SYSTEM_ENABLE_PROP;
5455
import static org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_STORAGE_MANAGER_CLASS_NAME_PROP;
5556
import static org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_STORAGE_MANAGER_CONFIG_PREFIX_PROP;
56-
import static org.apache.kafka.storage.internals.log.CleanerConfig.LOG_CLEANER_ENABLE_PROP;
5757

5858
public class TieredStorageTestUtils {
5959

@@ -103,6 +103,7 @@ public static List<Record> tieredStorageRecords(TieredStorageTestContext context
103103
.toList();
104104
}
105105

106+
@SuppressWarnings("removal")
106107
public static Properties createPropsForRemoteStorage(String testClassName,
107108
String storageDirPath,
108109
int brokerCount,
@@ -158,7 +159,7 @@ public static Properties createPropsForRemoteStorage(String testClassName,
158159
// Set 2 log dirs to make sure JBOD feature is working correctly
159160
overridingProps.setProperty(ServerLogConfigs.LOG_DIRS_CONFIG, TestUtils.tempDir().getAbsolutePath() + "," + TestUtils.tempDir().getAbsolutePath());
160161
// Disable unnecessary log cleaner
161-
overridingProps.setProperty(LOG_CLEANER_ENABLE_PROP, "false");
162+
overridingProps.setProperty(CleanerConfig.LOG_CLEANER_ENABLE_PROP, "false");
162163

163164
return overridingProps;
164165
}

0 commit comments

Comments
 (0)