HOTFIX: add SuppressWarnings in TieredStorageTestUtils #19494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
reviewed
Apr 16, 2025
| @@ -53,7 +54,6 @@ | |||
| import static org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_LOG_STORAGE_SYSTEM_ENABLE_PROP; | |||
| import static org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_STORAGE_MANAGER_CLASS_NAME_PROP; | |||
| import static org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig.REMOTE_STORAGE_MANAGER_CONFIG_PREFIX_PROP; | |||
| import static org.apache.kafka.storage.internals.log.CleanerConfig.LOG_CLEANER_ENABLE_PROP; | |||
There was a problem hiding this comment.
It seems we don't need this change, right?
There was a problem hiding this comment.
If we use static import, it will mark deprecated warning at import, thus I think we should not use static import
brandboat
approved these changes
Apr 16, 2025
chia7712
approved these changes
Apr 16, 2025
chia7712
changed the title
FrankYang0529
approved these changes
Apr 17, 2025
frankvicky
approved these changes
Apr 17, 2025
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
Apr 21, 2025
We need add SuppressWarnings annotation, because `log.cleaner.enable` mark deprecated. Reviewers: PoAn Yang <[email protected]>, Kuan-Po Tseng <[email protected]>, TengYao Chi <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need add SuppressWarnings annotation, because
log.cleaner.enablemark deprecated.
Reviewers: PoAn Yang [email protected], Kuan-Po Tseng
[email protected], TengYao Chi [email protected], Chia-Ping
Tsai [email protected]