KAFKA-18613: Unit tests for usage of incorrect RPCs #18383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbru
commented
Jan 3, 2025
| @@ -741,6 +741,7 @@ public List<StreamsGroupDescribeResponseData.DescribedGroup> streamsGroupDescrib | |||
| describedGroups.add(new StreamsGroupDescribeResponseData.DescribedGroup() | |||
| .setGroupId(groupId) | |||
| .setErrorCode(Errors.GROUP_ID_NOT_FOUND.code()) | |||
| .setErrorMessage(exception.getMessage()) | |||
There was a problem hiding this comment.
This was actually inconsistent to other group types
| @@ -18,6 +18,7 @@ | |||
| package org.apache.kafka.coordinator.group.taskassignor; | |||
|
|
|||
| import org.apache.kafka.coordinator.group.GroupCoordinatorConfig; | |||
|
|
|||
| @@ -9373,7 +9375,8 @@ public void testStreamsGroupDescribeBeforeAndAfterCommittingOffset() { | |||
| List<StreamsGroupDescribeResponseData.DescribedGroup> actual = context.groupMetadataManager.streamsGroupDescribe(Collections.singletonList(streamsGroupId), context.lastCommittedOffset); | |||
| StreamsGroupDescribeResponseData.DescribedGroup describedGroup = new StreamsGroupDescribeResponseData.DescribedGroup() | |||
| .setGroupId(streamsGroupId) | |||
| .setErrorCode(Errors.GROUP_ID_NOT_FOUND.code()); | |||
| .setErrorCode(Errors.GROUP_ID_NOT_FOUND.code()) | |||
| .setErrorMessage("Group " + streamsGroupId + " not found."); | |||
There was a problem hiding this comment.
Updates behavior according to the above change to production code.
| @@ -15673,6 +15676,349 @@ public void testReplayStreamsGroupTopologyTombstone() { | |||
| assertThrows(GroupIdNotFoundException.class, () -> context.groupMetadataManager.streamsGroup("bar")); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testConsumerGroupHeartbeatOnStreamsGroup() { | |||
There was a problem hiding this comment.
The test are pretty repetitive - like the ones for the other group types. I considered saving some LOC (by using private helper methods, and parametrized tests), but kept them at way, since it's going to be easier to refactor if each test is self-contained.
|
@bbejeck is this still on your list? |
lucasbru
force-pushed
the
kip1071pr/gmm_tests
branch
from
caa4e6c to
3df4603
Compare
github-actions
bot
added
streams
core
lucasbru
changed the title
|
I retargeted this to trunk (I thought I had already). The tests weren't changed. |
lucasbru
added
KIP-1071
lucasbru
force-pushed
the
kip1071pr/gmm_tests
branch
2 times, most recently
from
999d3be to
869234a
Compare
lucasbru
force-pushed
the
kip1071pr/gmm_tests
branch
from
869234a to
cbe6f3d
Compare
Tests for joining with missing source topics, internal topics, incorrectly partitioned topics, and stale topologies.
In the GroupMetadataManager, we may call an RPC on an incorrect group type. This adds unit tests to validate the behavior when an RPC is used on an incorrect group type.
lucasbru
force-pushed
the
kip1071pr/gmm_tests
branch
from
cbe6f3d to
3d71777
Compare
janchilling
pushed a commit
to janchilling/kafka
that referenced
this pull request
Apr 4, 2025
In the GroupMetadataManager, we may call an RPC on an incorrect group type. This adds unit tests to validate the behavior when an RPC is used on an incorrect group type. Reviewers: Bill Bejeck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the GroupMetadataManager, we may call an RPC on an incorrect group type. This adds unit tests to validate the behavior when an RPC is used on an incorrect group type.
Reviewers: Bill Bejeck [email protected]