Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18858: Refactor FeatureControlManager to avoid using uninitialized MV #19040

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

FrankYang0529
Copy link
Member

The FeatureControlManager used MetadataVersion#LATEST_PRODUCTION
as uninitialized MV. This makes other component may get a stale MV.
In production code, the FeatureControlManager set MV when replaying
FeatureLevelRecord, so we can set Optional.empty() as uninitialized MV.
If other components get an empty result, the FeatureLevelRecord throws
an exception like FeaturesImage.

Unit test:

  • FeatureControlManagerTest#testMetadataVersion: test getting MetadataVersion
    before and after replaying FeatureLevelRecord.

@github-actions github-actions bot added the kraft label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant