KAFKA-18858: Refactor FeatureControlManager to avoid using uninitialized MV #19040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FeatureControlManager
usedMetadataVersion#LATEST_PRODUCTION
as uninitialized MV. This makes other component may get a stale MV.
In production code, the
FeatureControlManager
set MV when replayingFeatureLevelRecord
, so we can setOptional.empty()
as uninitialized MV.If other components get an empty result, the
FeatureLevelRecord
throwsan exception like
FeaturesImage
.Unit test:
before and after replaying FeatureLevelRecord.