KAFKA-19042: [1/N] Move ConsumerTopicCreationTest to client-integration-tests module #19283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts module JIRA: KAFKA-19042 This patch moves ConsumerTopicCreationTest to the client-integration-tests and rewrite it as Java.
github-actions
bot
added
triage
m1a2st
reviewed
Mar 27, 2025
Comment on lines
112
to
119
| Map<String, Object> consumerConfig = Map.of( | ||
| CLIENT_ID_CONFIG, "ConsumerTestConsumer", | ||
| GROUP_ID_CONFIG, "TestGroup", | ||
| ALLOW_AUTO_CREATE_TOPICS_CONFIG, allowConsumerAutoCreateTopics, | ||
| GROUP_PROTOCOL_CONFIG, protocol.name().toLowerCase(Locale.ROOT), | ||
| BOOTSTRAP_SERVERS_CONFIG, bootstrapServer | ||
| ); | ||
| return new KafkaConsumer<>(consumerConfig, new ByteArrayDeserializer(), new ByteArrayDeserializer()); |
There was a problem hiding this comment.
Should use cluster.consumer() to create consumer.
chia7712
reviewed
Mar 27, 2025
There was a problem hiding this comment.
@frankvicky thanks for this patch. could you please refactor it to eliminate the duplicate code?
|
|
||
| private Consumer<byte[], byte[]> createConsumer(ClusterInstance cluster, GroupProtocol protocol, boolean allowConsumerAutoCreateTopics) { | ||
| Map<String, Object> consumerConfig = Map.of( | ||
| CLIENT_ID_CONFIG, "ConsumerTestConsumer", |
chia7712
reviewed
Mar 28, 2025
| } | ||
|
|
||
| private Set<String> getAllTopics(ClusterInstance cluster) { | ||
| return cluster.brokers().values().iterator().next().metadataCache().getAllTopics(); |
There was a problem hiding this comment.
Could you please avoid accessing broker? Maybe we can use Admin instead?
chia7712
approved these changes
Mar 31, 2025
janchilling
pushed a commit
to janchilling/kafka
that referenced
this pull request
Apr 4, 2025
…s module (apache#19283) This patch moves `ConsumerTopicCreationTest` to the `client-integration-tests` and rewrite it as Java. The patch also streamlines the test flow. In the Scala version, there is a producer that produces messages, but this is not the main purpose of the `ConsumerTopicCreationTest`. Reviewers: Ken Huang <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: KAFKA-19042
This patch moves
ConsumerTopicCreationTestto theclient-integration-testsand rewrite it as Java.The patch also streamlines the test flow.
In the Scala version, there is a producer that produces messages, but this is not the main purpose of the
ConsumerTopicCreationTest.Reviewers: Ken Huang [email protected], Chia-Ping Tsai [email protected]