MINOR: Cleanup Raft Module #19284
Merged
MINOR: Cleanup Raft Module #19284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @chia7712 |
chia7712
reviewed
Apr 1, 2025
There was a problem hiding this comment.
@sjhajharia thanks for this cleanup. only one comment is left.
m1a2st
reviewed
Apr 2, 2025
raft/src/test/java/org/apache/kafka/snapshot/SnapshotWriterReaderTest.java
Show resolved
Hide resolved
|
Thanks @m1a2st for the review. |
chia7712
approved these changes
Apr 2, 2025
janchilling
pushed a commit
to janchilling/kafka
that referenced
this pull request
Apr 4, 2025
Given that now we support Java 17 on our brokers, this PR replace the use of the following in raft module: - Collections.singletonList() and Collections.emptyList() with List.of() - Collections.singletonMap() and Collections.emptyMap() with Map.of() - Collections.singleton() and Collections.emptySet() with Set.of() - Arrays.asList() with List.of() Reviewers: Ken Huang <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that now we support Java 17 on our brokers, this PR replace the use of the following in raft module:
Reviewers: Ken Huang [email protected], Chia-Ping Tsai [email protected]