MINOR: Refactor GroupCoordinator write path #19290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to add a unit tests for the new method. |
jeffkbkim
reviewed
Mar 27, 2025
dajac
added a commit
that referenced
this pull request
Mar 31, 2025
This is a small follow-up of #19290. The `actionQueue` argument is only used by the `CoordinatorPartitionWriter` so we can remove it from the other methods now. Reviewers: Jeff Kim <[email protected]>
janchilling
pushed a commit
to janchilling/kafka
that referenced
this pull request
Apr 4, 2025
This patch addresses a weirdness on the GroupCoordinator write path. The `CoordinatorPartitionWriter` uses the `ReplicaManager#appendRecords` method with `acks=1` and it expects it to completes immediately/synchronously. It works because this is effectively what the method does with `acks=1`. The issue is that fundamentally the method is asynchronous so the contract is really fragile. This patch changes it by introducing new method `ReplicaManager.appendRecordsToLeader`, which is synchronous. It also refactors `ReplicaManager#appendRecords` to use `ReplicaManager.appendRecordsToLeader` so we can benefits from all the existing tests. Reviewers: Fred Zheng <[email protected]>, Jeff Kim <[email protected]>
janchilling
pushed a commit
to janchilling/kafka
that referenced
this pull request
Apr 4, 2025
This is a small follow-up of apache#19290. The `actionQueue` argument is only used by the `CoordinatorPartitionWriter` so we can remove it from the other methods now. Reviewers: Jeff Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses a weirdness on the GroupCoordinator write path. The
CoordinatorPartitionWriteruses theReplicaManager#appendRecordsmethod withacks=1and it expects it to completes immediately/synchronously. It works because this is effectively what the method does withacks=1. The issue is that fundamentally the method is asynchronous so the contract is really fragile. This patch changes it by introducing new methodReplicaManager.appendRecordsToLeader, which is synchronous. It also refactorsReplicaManager#appendRecordsto useReplicaManager.appendRecordsToLeaderso we can benefits from all the existing tests.Reviewers: Fred Zheng [email protected], Jeff Kim [email protected]