KAFKA-19058 Running the streams/streams-scala module tests produces a streams-scala.log

[m1a2st]

Remove streams-scala module log4j2 file appender.

Reviewers: PoAn Yang [email protected], Matthias J. Sax [email protected]

[m1a2st]

use command ./gradlew clean :streams:streams-scala:test in my local

[mjsax]

I am ok with this change, but I don't understand the problem? The Jira say

Running tests should not produce untracked files.

What do you mean by this? logs is part of .gitignore similar build/

https://github.com/apache/kafka/blob/trunk/.gitignore#L32
https://github.com/apache/kafka/blob/trunk/.gitignore#L5

So I don't see a difference?

Also, comparing the log4j2.yaml with other in streams context, the other don't configure any file appender, so I am wondering if we should not just change the directory, but remove the file appender entirely?

[m1a2st]

Hello @mjsax. thanks for review

What do you mean by this? logs is part of .gitignore similar build/

filePattern: "streams-scala-%d{yyyy-MM-dd}.log" this is leak, When I test on trunk, it will generate the streams-scala log file.

Also, comparing the log4j2.yaml with other in streams context, the other don't configure any file appender, so I am wondering if we should not just change the directory, but remove the file appender entirely?

I'm not sure why we're using a file appender, but if we don't check the log files, removing the appender seems like a good approach.

[FrankYang0529]

Also, comparing the log4j2.yaml with other in streams context, the other don't configure any file appender, so I am wondering if we should not just change the directory, but remove the file appender entirely?

I'm not sure why we're using a file appender, but if we don't check the log files, removing the appender seems like a good approach.

It looks like the file appender was introduced by #4756. There is no more information why we did it. I'm +1 to remove the appender.

[mjsax]

Seems we all agree that removing the file appender is the best thing to do.

[m1a2st]

test on my local machine

[mjsax]

nit: can we rename this to STDOUT ?

[m1a2st]

Sure, addressed it.

[FrankYang0529]

LGTM. Thanks for the patch.