KAFKA-19062: Port changes from KAFKA-18645 to share-consumers #19335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
consumer
clients
small
ShivsundarR
changed the title
AndrewJSchofield
added
KIP-932
AndrewJSchofield
requested changes
Apr 1, 2025
| * <p> | ||
| * The actual maximum wait time is bounded by the {@link ConsumerConfig#REQUEST_TIMEOUT_MS_CONFIG} setting, which | ||
| * only applies to operations performed with the broker (coordinator-related requests and | ||
| * fetch sessions). Even if a larger timeout is specified, the consumer will not wait longer than |
There was a problem hiding this comment.
nit: "fetch session" is not a thing for a share consumer. Maybe "operations performed with the broker, such as coordinator-related requests." would suffice.
| @@ -250,6 +251,7 @@ private enum AcknowledgementMode { | |||
| this.log = logContext.logger(getClass()); | |||
|
|
|||
| log.debug("Initializing the Kafka share consumer"); | |||
| this.requestTimeoutMs = config.getInt(ConsumerConfig.REQUEST_TIMEOUT_MS_CONFIG); | |||
| this.defaultApiTimeoutMs = config.getInt(ConsumerConfig.DEFAULT_API_TIMEOUT_MS_CONFIG); | |||
There was a problem hiding this comment.
It seems to me that requestTimeoutMs and defaultApiTimeoutMs ought to have the same data type. Please choose the best one and make them the same, which I have a feeling would be int.
There was a problem hiding this comment.
Okay, yeah makes sense. I have updated it to int. Thanks.
frankvicky
approved these changes
Apr 1, 2025
AndrewJSchofield
approved these changes
Apr 1, 2025
janchilling
pushed a commit
to janchilling/kafka
that referenced
this pull request
Apr 4, 2025
…#19335) Limits waiting when closing a share consumer to request.timeout.ms. Reviewers: Andrew Schofield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-19062
After 6636316 , we handle the close timeout in
AsyncKafkaConsumerby taking the minimum of user given timeout and the default request timeout config.These changes need to applied to ShareConsumers as well.