Skip to content

MINOR: Supress stdout when checking Log4j 1.x configuration compatibility mode #19502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

MINOR: Supress stdout when checking Log4j 1.x configuration compatibility mode #19502

merged 1 commit into from
Apr 17, 2025

Conversation

omkreddy
Copy link
Contributor

@omkreddy omkreddy commented Apr 17, 2025 •
edited by github-actions bot
Loading

when using log41 config, we are printing addtional line like below. This
PR is to fix that.

For example, cmd bin/kafka-storage.sh random-uuid gives

-Dlog4j.configuration=file:/Users/manikumar/releases/log4j.properties
DEPRECATED: A Log4j 1.x configuration file has been detected, which is
no longer recommended.
To use a Log4j 2.x configuration, please see
https://logging.apache.org/log4j/2.x/migrate-from-log4j1.html#Log4j2ConfigurationFormat
for details about Log4j configuration file migration.
You can also use the $KAFKA_HOME/config/tools-log4j2.yaml file as a
starting point. Make sure to remove the Log4j 1.x configuration after
completing the migration.
[2025-04-17 11:45:24,697] INFO Registered
kafka:type=kafka.Log4jController MBean
(kafka.utils.Log4jControllerRegistration$)
ul14bI6fSnmRYTWa6MnzOQ

@github-actions github-actions bot added triage PRs from the community small Small PRs labels Apr 17, 2025
frankvicky
frankvicky approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omkreddy: Thanks for the improvement!
LGTM

@omkreddy omkreddy merged commit bb7d8eb into apache:trunk Apr 17, 2025
25 checks passed
omkreddy added a commit that referenced this pull request Apr 17, 2025
@omkreddy
MINOR: Supress stdout when checking Log4j 1.x configuration compatibi…
56743b3 
…lity mode (#19502)

when using log41 config, we are printing addtional line like below. This
PR is to fix that.
@github-actions github-actions bot removed the triage PRs from the community label Apr 18, 2025
rreddy-22 pushed a commit to rreddy-22/kafka-rreddy that referenced this pull request Apr 21, 2025
@omkreddy @rreddy-22
MINOR: Supress stdout when checking Log4j 1.x configuration compatibi…
e89defd 
…lity mode (apache#19502)

when using log41 config, we are printing addtional line like below. This
PR is to fix that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankvicky frankvicky frankvicky approved these changes

Assignees
No one assigned
Labels
small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omkreddy @frankvicky