KAFKA-10357 accidental repartition handling

streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java

@@ -45,6 +45,10 @@
 import org.apache.kafka.common.utils.Utils;
 import org.apache.kafka.streams.errors.InvalidStateStoreException;
 import org.apache.kafka.streams.errors.InvalidStateStorePartitionException;
+import org.apache.kafka.streams.errors.MissingSourceTopicException;
+import org.apache.kafka.streams.errors.MisconfiguredInternalTopicException;
+import org.apache.kafka.streams.errors.MissingInternalTopicsException;
+import org.apache.kafka.streams.errors.InternalTopicsAlreadySetupException;
 import org.apache.kafka.streams.errors.ProcessorStateException;
 import org.apache.kafka.streams.errors.StreamsException;
 import org.apache.kafka.streams.errors.StreamsNotStartedException;
@@ -61,6 +65,9 @@
 import org.apache.kafka.streams.processor.TaskId;
 import org.apache.kafka.streams.processor.internals.ClientUtils;
 import org.apache.kafka.streams.processor.internals.GlobalStreamThread;
+import org.apache.kafka.streams.processor.internals.InternalTopicManager;
+import org.apache.kafka.streams.processor.internals.InternalTopicConfig;
+import org.apache.kafka.streams.processor.internals.InternalTopologyBuilder;
 import org.apache.kafka.streams.processor.internals.StateDirectory;
 import org.apache.kafka.streams.processor.internals.StreamThread;
 import org.apache.kafka.streams.processor.internals.StreamsMetadataState;
@@ -69,6 +76,7 @@
 import org.apache.kafka.streams.processor.internals.TopologyMetadata;
 import org.apache.kafka.streams.processor.internals.metrics.StreamsMetricsImpl;
 import org.apache.kafka.streams.processor.internals.namedtopology.NamedTopology;
+import org.apache.kafka.streams.processor.internals.InternalTopicManager.ValidationResult;
 import org.apache.kafka.streams.query.FailureReason;
 import org.apache.kafka.streams.query.PositionBound;
 import org.apache.kafka.streams.query.QueryConfig;
@@ -111,6 +119,7 @@
 import java.util.stream.Collectors;
 
 import static org.apache.kafka.streams.StreamsConfig.METRICS_RECORDING_LEVEL_CONFIG;
+import static org.apache.kafka.streams.StreamsConfig.DEFAULT_INIT_TIMEOUT_MS;
 import static org.apache.kafka.streams.errors.StreamsUncaughtExceptionHandler.StreamThreadExceptionResponse.SHUTDOWN_CLIENT;
 import static org.apache.kafka.streams.internals.ApiUtils.prepareMillisCheckFailMsgPrefix;
 import static org.apache.kafka.streams.internals.ApiUtils.validateMillisecondDuration;
@@ -293,6 +302,168 @@ public boolean isValidTransition(final State newState) {
     private final Object stateLock = new Object();
     protected volatile State state = State.CREATED;
 
+    /**
+     * Initializes broker-side state.
+     *
+     * @throws MissingSourceTopicException         if a source topic is missing
+     * @throws MissingInternalTopicsException      if some but not all of the internal topics are missing
+     * @throws MisconfiguredInternalTopicException if an internal topics is misconfigured
+     * @throws InternalTopicsAlreadySetupException if all internal topics are already setup
+     */
+    public void init() {
+        this.init(DEFAULT_INIT_TIMEOUT_MS);
+    }
+
+    /**
+     * Initializes broker-side state.
+     *
+     * @throws MissingSourceTopicException         if a source topic is missing
+     * @throws MissingInternalTopicsException      if some but not all of the internal topics are missing
+     * @throws MisconfiguredInternalTopicException if an internal topics is misconfigured
+     * @throws InternalTopicsAlreadySetupException if all internal topics are already setup
+     * @throws TimeoutException                    if initialization exceeds the given timeout
+     */
+
+    public void init(final Duration timeout) {
+        final InitParameters initParameters = InitParameters.initParameters();
+        initParameters.setTimeout(timeout);
+
+        this.doInit(InitParameters.initParameters());
+    }
+
+    /**
+     * Initializes broker-side state.
+     *
+     * This methods takes parameters that specify which internal topics to setup if some
+     * but not all of them are absent.
+     *
+     * @throws MissingSourceTopicException         if a source topic is missing
+     * @throws MissingInternalTopicsException      if some but not all of the internal topics are missing
+     *                                            and the given initialization parameters do not specify to setup them
+     * @throws MisconfiguredInternalTopicException if an internal topics is misconfigured
+     * @throws InternalTopicsAlreadySetupException if all internal topics are already setup
+     */
+
+    public void init(final InitParameters initParameters) {
+        this.doInit(initParameters);
+    }
+
+    /**
+     * Initializes broker-side state.
+     *
+     * This methods takes parameters that specify which internal topics to setup if some
+     * but not all of them are absent.
+     *
+     * @throws MissingSourceTopicException         if a source topic is missing
+     * @throws MissingInternalTopicsException      if some but not all of the internal topics are missing
+     *                                            and the given initialization parameters do not specify to setup them
+     * @throws MisconfiguredInternalTopicException if an internal topics is misconfigured
+     * @throws InternalTopicsAlreadySetupException if all internal topics are already setup
+     * @throws TimeoutException                    if initialization exceeds the given timeout
+     */
+    public void init(final InitParameters initParameters, final Duration timeout) {
+        initParameters.enableTimeout();
+        initParameters.setTimeout(timeout);
+
+        this.doInit(initParameters);
+    }
+
+    private void doInit(final InitParameters initParameters) {
+        final InternalTopicManager internalTopicManager = new InternalTopicManager(time, adminClient, applicationConfigs);
+        if (initParameters.hasTimeoutEnabled()) {
+            internalTopicManager.setInitTimeout(initParameters.getTimeout());
+        }
+
+        final Map<String, InternalTopicConfig> allInternalTopics = new HashMap<>();
+        final Set<String> allSourceTopics = new HashSet<>();
+        for (final Map<TopologyMetadata.Subtopology, InternalTopologyBuilder.TopicsInfo> subtopologyMap : topologyMetadata.topologyToSubtopologyTopicsInfoMap().values()) {
+            for (final InternalTopologyBuilder.TopicsInfo topicsInfo : subtopologyMap.values()) {
+                allInternalTopics.putAll(topicsInfo.stateChangelogTopics);
+                allInternalTopics.putAll(topicsInfo.repartitionSourceTopics);
+                allSourceTopics.addAll(topicsInfo.sourceTopics);
+            }
+        }
+        try {
+            final ValidationResult validationResult = internalTopicManager.validate(allInternalTopics); // can throw timeout
+
+            final boolean noInternalTopicsExist = allInternalTopics.keySet() == validationResult.missingTopics();
+            final boolean internalTopicsMisconfigured = !validationResult.misconfigurationsForTopics().isEmpty();
+            final boolean allInternalTopicsExist = validationResult.missingTopics().isEmpty();
+            final boolean missingSourceTopics = !Collections.disjoint(validationResult.missingTopics(), allSourceTopics);
+
+            if (internalTopicsMisconfigured) {
+                throw new MisconfiguredInternalTopicException("Misconfigured Internal Topics: " + validationResult.misconfigurationsForTopics());
+            }
+            if (missingSourceTopics) {
+                allSourceTopics.retainAll(validationResult.missingTopics());
+                throw new MissingSourceTopicException("Missing source topics: " + allSourceTopics);
+            }
+            if (noInternalTopicsExist) {
+                internalTopicManager.setup(allInternalTopics);
+            } else if (allInternalTopicsExist) {
+                throw new InternalTopicsAlreadySetupException("All internal topics have already been setup");
+            } else {
+                if (initParameters.setupInternalTopicsIfIncompleteEnabled()) {
+                    final Map<String, InternalTopicConfig> topicsToCreate = new HashMap<>();
+                    for (final String missingTopic : validationResult.missingTopics()) {
+                        topicsToCreate.put(missingTopic, allInternalTopics.get(missingTopic));
+                    }
+                    internalTopicManager.makeReady(topicsToCreate);
+                } else {
+                    throw new MissingInternalTopicsException("Missing Internal Topics: ", new ArrayList<>(validationResult.missingTopics()));
+                }
+            }
+        } catch (final TimeoutException timeoutException) {
+            throw new TimeoutException(timeoutException.getMessage(), timeoutException);
+        } catch (final StreamsException streamsException) {
+            throw new StreamsException(streamsException.getMessage(), streamsException);
+        }
+    }
+
+    public static class InitParameters {
+        private boolean timeoutEnabled;
+        private Duration timeout;
+        private final boolean setupInternalTopicsIfIncomplete;
+
+        private InitParameters(final boolean setupInternalTopicsIfIncomplete) {
+            this.setupInternalTopicsIfIncomplete = setupInternalTopicsIfIncomplete;
+        }
+
+        // Default: don't create missing topics if only some are missing
+        public static InitParameters initParameters() {
+            return new InitParameters(false);
+        }
+
+        public InitParameters enableSetupInternalTopicsIfIncomplete() {
+            return new InitParameters(true);
+        }
+
+        public InitParameters disableSetupInternalTopicsIfIncomplete() {
+            return new InitParameters(false);
+        }
+
+        public boolean setupInternalTopicsIfIncompleteEnabled() {
+            return setupInternalTopicsIfIncomplete;
+        }
+
+        public final void enableTimeout() {
+            this.timeoutEnabled = true;
+        }
+
+        public final boolean hasTimeoutEnabled() {
+            return timeoutEnabled;
+        }
+
+        public final void setTimeout(final Duration timeout) {
+            this.timeout = timeout;
+        }
+
+        public final Duration getTimeout() {
+            return this.timeout;
+        }
+
+    }
+
     private boolean waitOnStates(final long waitMs, final State... targetStates) {
         final Set<State> targetStateSet = Set.of(targetStates);
         final long begin = time.milliseconds();

streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java

@@ -173,6 +173,7 @@ public class StreamsConfig extends AbstractConfig {
 
     public static final long MAX_TASK_IDLE_MS_DISABLED = -1;
 
+    public static final Duration DEFAULT_INIT_TIMEOUT_MS = Duration.ofMillis(30000);
     // We impose these limitations because client tags are encoded into the subscription info,
     // which is part of the group metadata message that is persisted into the internal topic.
     public static final int MAX_RACK_AWARE_ASSIGNMENT_TAG_LIST_SIZE = 5;
@@ -885,6 +886,14 @@ public class StreamsConfig extends AbstractConfig {
             ProducerConfig.TRANSACTIONAL_ID_CONFIG
         };
 
+    public static final String INTERNAL_TOPIC_SETUP_CONFIG = "internal.topics.setup";
+    public static final String INTERNAL_TOPIC_SETUP_AUTOMATIC = "automatic";
+    public static final String INTERNAL_TOPIC_SETUP_MANUAL = "manual";
+    private static final String INTERNAL_TOPIC_SETUP_DOC = 
+        "Configures how internal topics (e.g., repartition or changelog topics) should be created. " +
+        "Set to 'automatic' to allow internal topics to be created during a rebalance (default). " +
+        "Set to 'manual' to disable automatic creation. Users must call KafkaStreams#init() instead.";
+
     static {
         CONFIG = new ConfigDef()
 
@@ -1012,6 +1021,12 @@ public class StreamsConfig extends AbstractConfig {
                     LogAndFailProcessingExceptionHandler.class.getName(),
                     Importance.MEDIUM,
                     PROCESSING_EXCEPTION_HANDLER_CLASS_DOC)
+            .define(INTERNAL_TOPIC_SETUP_CONFIG,
+                    ConfigDef.Type.STRING,
+                    INTERNAL_TOPIC_SETUP_AUTOMATIC,
+                    ConfigDef.ValidString.in(INTERNAL_TOPIC_SETUP_AUTOMATIC, INTERNAL_TOPIC_SETUP_MANUAL),
+                    Importance.MEDIUM,
+                    INTERNAL_TOPIC_SETUP_DOC)
             .define(PROCESSING_GUARANTEE_CONFIG,
                     Type.STRING,
                     AT_LEAST_ONCE,

streams/src/main/java/org/apache/kafka/streams/errors/InternalTopicsAlreadySetupException.java

@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.errors;
+
+public class InternalTopicsAlreadySetupException extends StreamsException {
+
+    private static final long serialVersionUID = 1L;
+
+    public InternalTopicsAlreadySetupException(final String message) {
+        super(message);
+    }
+}

streams/src/main/java/org/apache/kafka/streams/errors/MisconfiguredInternalTopicException.java

@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.errors;
+
+public class MisconfiguredInternalTopicException extends StreamsException {
+
+    private static final long serialVersionUID = 1L;
+
+    public MisconfiguredInternalTopicException(final String message) {
+        super(message);
+    }
+}

streams/src/main/java/org/apache/kafka/streams/errors/MissingInternalTopicsException.java

@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.errors;
+
+import java.util.List;
+
+public class MissingInternalTopicsException extends StreamsException {
+
+    private static final long serialVersionUID = 1L;
+
+    private final List<String> topics;
+
+    /** 
+     * Constructs a new MissingInternalTopicsException.
+     * 
+     * @param message The detail message
+     * @param topics the list of missing internal topic names
+     */
+    public MissingInternalTopicsException(final String message, final List<String> topics) {
+        super(message);
+        this.topics = topics;
+    }
+
+    /**
+     * Returns the list of missing internal topics that caused the exception.
+     */
+    public List<String> topics() {
+        return topics;
+    }
+}

streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogTopics.java

@@ -135,4 +135,4 @@ public Set<TaskId> statefulTaskIds() {
     public Map<TaskId, Set<TopicPartition>> changelogPartionsForTask() {
         return Collections.unmodifiableMap(changelogPartitionsForStatefulTask);
     }
-}
+}