MINOR: Fix duplicate IPv6 entries in ducker-ak #19926
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
DL1231
reviewed
Jun 9, 2025
| [[ $? -ne 0 ]] && die "failed to append to the /etc/hosts file on ${node}" | ||
| else | ||
| docker exec --user=root "${node}" \ | ||
| bash -c "grep -v ${node} /opt/kafka-dev/tests/docker/build/node_hosts >> /etc/hosts" |
There was a problem hiding this comment.
Why is the IPv4 address filtered to remove "self", while the IPv6 address does not filter out "self"?
There was a problem hiding this comment.
I think we should do this.
@kevin-wu24 What do you think as the author of #19537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where, when using IPv6, IPv6 entries are appended twice to
/etc/hosts, resulting in duplicate lines.