Skip to content

NIFI-14678 Aligned the JoltTransformJSON tags with the Jolt DSL names. #10034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Jun 20, 2025

Summary

NIFI-14678

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggesting these additional tags @dan-s1.

In this case, I don't think it is necessary or helpful to include every Jolt operation as a tag. Tags can be used for various purposes, for documentation and feature discovery, but enumerating all possible options starts to go beyond general usage.

However, following from your question in the Jira issue, I do agree that it would be better to align the tags with the DSL names from the Jolt documentation, so repurposing this Jira and pull request to align the tags with those DSL names (shift instead of shiftr), would be helpful.

@dan-s1 dan-s1 changed the title NIFI-14678 Added tags to JoltTransformJSON for Jolt advanced operations. NIFI-14678 Aligned the JoltTransformJSON tags with the Jolt DSL names. Jun 23, 2025
@dan-s1 dan-s1 requested a review from exceptionfactory June 23, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants