Skip to content

GitHub Workflows security hardening #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

sashashura
Copy link
Contributor

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.
It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

@exceptionfactory
Copy link
Contributor

Thanks for the contribution @sashashura, this looks like a helpful improvement to the workflow configurations.

As noted in the Pull Request Template, all changes need to have an associated Apache NiFi Jira issue for tracking. The Apache NiFi Jira project is available at the following location:

https://issues.apache.org/jira/projects/NIFI

If you can create an issue and update this pull request with the reference issue number, that would be helpful.

@exceptionfactory
Copy link
Contributor

Thanks again for the contribution @sashashura! I am closing this PR in favor of #6469 with associated Jira issue NIFI-10575, but I listed you as a co-author in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants