Fetch writer schema to decode Avro messages #119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108
Motivation
Currently the Python client uses the reader schema, which is the schema of the consumer, to decode Avro messages. However, when the writer schema is different from the reader schema, the decode will fail.
Modifications
Add
attach_client
method toSchema
and call it when creating consumers and readers. This method stores a reference to a_pulsar.Client
instance, which leverages the C++ APIs added in apache/pulsar-client-cpp#257 to fetch schema info. TheAvroSchema
class fetches and caches the writer schema if it is not cached, then use both the writer schema and reader schema to decode messages.Add
test_schema_evolve
to test consumers or readers can decode any message whose writer schema is different with the reader schema.