Skip to content

[feat] Support consumer batch receive. #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

shibd
Copy link
Member

@shibd shibd commented Nov 10, 2022

Motivation

#39

Modifications

  • Support consumer batch receive.

Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you wrap the BatchReceivePolicy class into the pulsar module? It's better to avoid using the class from _pulsar module directly.

@shibd
Copy link
Member Author

shibd commented Nov 10, 2022

Could you wrap the BatchReceivePolicy class into the pulsar module? It's better to avoid using the class from _pulsar module directly.

Yes, When I coded, I struggled with whether to implement a wrapper. It turns out that implementing a wrapper class can clearly define the input parameters and docs.

I changed it, PTAL.

@shibd shibd requested a review from BewareMyPower November 10, 2022 15:30
@tisonkun
Copy link
Member

@shibd you may try to rebase on the latest master so that we're sure there's no doc string syntax regression :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants